On Fri 2015-10-09 10:08:12, Jacek Anaszewski wrote:
> On 10/09/2015 09:02 AM, Pavel Machek wrote:
> >On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
> >>On 10/08/2015 05:50 PM, Pavel Machek wrote:
> >>>On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> This patch removes
On 10/09/2015 09:02 AM, Pavel Machek wrote:
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
On 10/08/2015 05:50 PM, Pavel Machek wrote:
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
> On 10/08/2015 05:50 PM, Pavel Machek wrote:
> >On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> >>This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
>
> s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/
>
> >>led_set_brightness now
On 10/08/2015 05:50 PM, Pavel Machek wrote:
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/
led_set_brightness now calls led_set_brightness_nosleep instead of
choosing between sync
On 10/08/2015 05:50 PM, Pavel Machek wrote:
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/
led_set_brightness now calls led_set_brightness_nosleep instead of
choosing between sync
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
> On 10/08/2015 05:50 PM, Pavel Machek wrote:
> >On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> >>This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
>
> s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/
>
> >>led_set_brightness now
On 10/09/2015 09:02 AM, Pavel Machek wrote:
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
On 10/08/2015 05:50 PM, Pavel Machek wrote:
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
On Fri 2015-10-09 10:08:12, Jacek Anaszewski wrote:
> On 10/09/2015 09:02 AM, Pavel Machek wrote:
> >On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
> >>On 10/08/2015 05:50 PM, Pavel Machek wrote:
> >>>On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> This patch removes
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
> led_set_brightness now calls led_set_brightness_nosleep instead of
> choosing between sync and async op basing on the flags defined by the
> driver.
Are those flags unused in
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
> led_set_brightness now calls led_set_brightness_nosleep instead of
> choosing between sync and async op basing on the flags defined by the
> driver.
Are those flags unused in
> +int led_set_brightness_sync(struct led_classdev *led_cdev,
> + enum led_brightness value)
> +{
> + WARN_ON(led_cdev->blink_delay_on || led_cdev->blink_delay_off);
> +
> + led_cdev->brightness = min(value, led_cdev->max_brightness);
> +
> + if (led_cdev->flags
Hi Sakari,
Thanks for the review.
Just to avoid a confusion - this patch set depends on [1], which is
not merged yet and also needs a review. I reimplemented and split [2]
into two patch sets, so that [1] contained only modifications required
for removing work queues from LED class drivers, but
Hi Jacek,
Thanks for the patchset. A few comments below.
Jacek Anaszewski wrote:
> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
> led_set_brightness now calls led_set_brightness_nosleep instead of
> choosing between sync and async op basing on the flags defined by the
>
> +int led_set_brightness_sync(struct led_classdev *led_cdev,
> + enum led_brightness value)
> +{
> + WARN_ON(led_cdev->blink_delay_on || led_cdev->blink_delay_off);
> +
> + led_cdev->brightness = min(value, led_cdev->max_brightness);
> +
> + if (led_cdev->flags
Hi Jacek,
Thanks for the patchset. A few comments below.
Jacek Anaszewski wrote:
> This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
> led_set_brightness now calls led_set_brightness_nosleep instead of
> choosing between sync and async op basing on the flags defined by the
>
Hi Sakari,
Thanks for the review.
Just to avoid a confusion - this patch set depends on [1], which is
not merged yet and also needs a review. I reimplemented and split [2]
into two patch sets, so that [1] contained only modifications required
for removing work queues from LED class drivers, but
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
led_set_brightness now calls led_set_brightness_nosleep instead of
choosing between sync and async op basing on the flags defined by the
driver.
>From now on, if a user wants to make sure that brightness will be set
synchronously,
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.
led_set_brightness now calls led_set_brightness_nosleep instead of
choosing between sync and async op basing on the flags defined by the
driver.
>From now on, if a user wants to make sure that brightness will be set
synchronously,
18 matches
Mail list logo
