Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hey Andi, thanks for the feedback. I will fix that in the next version of this patch series! On 18.12.2017 03:44, Andi Shyti wrote: Hi Philipp, just a couple of small nitpicks. + u32 b_clk_freq; [...] + /* Base clock frequency (optional) */ + if

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hey Andi, thanks for the feedback. I will fix that in the next version of this patch series! On 18.12.2017 03:44, Andi Shyti wrote: Hi Philipp, just a couple of small nitpicks. + u32 b_clk_freq; [...] + /* Base clock frequency (optional) */ + if

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hi Philipp, just a couple of small nitpicks. > + u32 b_clk_freq; [...] > + /* Base clock frequency (optional) */ > + if (of_property_read_u32(dn, "clock-frequency", _clk_freq)) { > + b_clk_freq = SUNXI_IR_BASE_CLK; > + } > + how about you intialize 'b_clk_freq' to

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hi Philipp, just a couple of small nitpicks. > + u32 b_clk_freq; [...] > + /* Base clock frequency (optional) */ > + if (of_property_read_u32(dn, "clock-frequency", _clk_freq)) { > + b_clk_freq = SUNXI_IR_BASE_CLK; > + } > + how about you intialize 'b_clk_freq' to

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

On Sun, Dec 17, 2017 at 11:45:43PM +0100, Philipp Rossak wrote: > This patch updates the sunxi-ir driver to set the base clock frequency from > devicetree. > > This is neccessary since there are different ir recievers on the > market, that operate with different frequencys. So this value could be

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

On Sun, Dec 17, 2017 at 11:45:43PM +0100, Philipp Rossak wrote: > This patch updates the sunxi-ir driver to set the base clock frequency from > devicetree. > > This is neccessary since there are different ir recievers on the > market, that operate with different frequencys. So this value could be

[PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

This patch updates the sunxi-ir driver to set the base clock frequency from devicetree. This is neccessary since there are different ir recievers on the market, that operate with different frequencys. So this value could be set if the attached ir receiver needs an other base clock frequency, than

[PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

This patch updates the sunxi-ir driver to set the base clock frequency from devicetree. This is neccessary since there are different ir recievers on the market, that operate with different frequencys. So this value could be set if the attached ir receiver needs an other base clock frequency, than