Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-26 Thread Michal Hocko
On Mon 23-01-17 13:16:37, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order and don't match

Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-26 Thread Michal Hocko
On Mon 23-01-17 13:16:37, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order and don't match

Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-26 Thread Mel Gorman
On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order

Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-26 Thread Mel Gorman
On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order

Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-25 Thread Minchan Kim
On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order

Re: [PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-25 Thread Minchan Kim
On Mon, Jan 23, 2017 at 01:16:37PM -0500, Johannes Weiner wrote: > We have an elaborate dirty/writeback throttling mechanism inside the > reclaim scanner, but for that to work the pages have to go through > shrink_page_list() and get counted for what they are. Otherwise, we > mess up the LRU order

[PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-23 Thread Johannes Weiner
We have an elaborate dirty/writeback throttling mechanism inside the reclaim scanner, but for that to work the pages have to go through shrink_page_list() and get counted for what they are. Otherwise, we mess up the LRU order and don't match reclaim speed to writeback. Especially during

[PATCH 1/5] mm: vmscan: scan dirty pages even in laptop mode

2017-01-23 Thread Johannes Weiner
We have an elaborate dirty/writeback throttling mechanism inside the reclaim scanner, but for that to work the pages have to go through shrink_page_list() and get counted for what they are. Otherwise, we mess up the LRU order and don't match reclaim speed to writeback. Especially during