Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-16 Thread Vladimir Davydov
On 01/16/2014 02:53 AM, Andrew Morton wrote: > On Wed, 15 Jan 2014 19:55:11 +0400 Vladimir Davydov > wrote: > >>> We could avoid the "scan 32 then scan just 1" issue with something like >>> >>> if (total_scan > batch_size) >>> total_scan %= batch_size; >>> >>> before the loop.

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-16 Thread Vladimir Davydov
On 01/16/2014 02:53 AM, Andrew Morton wrote: On Wed, 15 Jan 2014 19:55:11 +0400 Vladimir Davydov vdavy...@parallels.com wrote: We could avoid the scan 32 then scan just 1 issue with something like if (total_scan batch_size) total_scan %= batch_size; before the loop. But

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Andrew Morton
On Wed, 15 Jan 2014 19:55:11 +0400 Vladimir Davydov wrote: > > > > We could avoid the "scan 32 then scan just 1" issue with something like > > > > if (total_scan > batch_size) > > total_scan %= batch_size; > > > > before the loop. But I expect the effects of that will be

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Vladimir Davydov
On 01/15/2014 01:25 PM, Andrew Morton wrote: > On Wed, 15 Jan 2014 12:47:35 +0400 Vladimir Davydov > wrote: > >> On 01/15/2014 02:14 AM, Andrew Morton wrote: >>> On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov >>> wrote: >>> On 01/14/2014 03:05 AM, Andrew Morton wrote: > That

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Andrew Morton
On Wed, 15 Jan 2014 12:47:35 +0400 Vladimir Davydov wrote: > On 01/15/2014 02:14 AM, Andrew Morton wrote: > > On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov > > wrote: > > > >> On 01/14/2014 03:05 AM, Andrew Morton wrote: > >>> That being said, I think I'll schedule this patch as-is for

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Vladimir Davydov
On 01/15/2014 02:14 AM, Andrew Morton wrote: > On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov > wrote: > >> On 01/14/2014 03:05 AM, Andrew Morton wrote: >>> That being said, I think I'll schedule this patch as-is for 3.14. Can >>> you please take a look at implementing the simpler

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Vladimir Davydov
On 01/15/2014 02:14 AM, Andrew Morton wrote: On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/14/2014 03:05 AM, Andrew Morton wrote: That being said, I think I'll schedule this patch as-is for 3.14. Can you please take a look at implementing the

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Andrew Morton
On Wed, 15 Jan 2014 12:47:35 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/15/2014 02:14 AM, Andrew Morton wrote: On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/14/2014 03:05 AM, Andrew Morton wrote: That being said, I think I'll

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Vladimir Davydov
On 01/15/2014 01:25 PM, Andrew Morton wrote: On Wed, 15 Jan 2014 12:47:35 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/15/2014 02:14 AM, Andrew Morton wrote: On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/14/2014 03:05 AM, Andrew

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-15 Thread Andrew Morton
On Wed, 15 Jan 2014 19:55:11 +0400 Vladimir Davydov vdavy...@parallels.com wrote: We could avoid the scan 32 then scan just 1 issue with something like if (total_scan batch_size) total_scan %= batch_size; before the loop. But I expect the effects of that will be

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-14 Thread Andrew Morton
On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov wrote: > On 01/14/2014 03:05 AM, Andrew Morton wrote: > > On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov > > wrote: > > > >> When reclaiming kmem, we currently don't scan slabs that have less than > >> batch_size objects (see

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-14 Thread Andrew Morton
On Tue, 14 Jan 2014 11:23:30 +0400 Vladimir Davydov vdavy...@parallels.com wrote: On 01/14/2014 03:05 AM, Andrew Morton wrote: On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov vdavy...@parallels.com wrote: When reclaiming kmem, we currently don't scan slabs that have less than

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-13 Thread Vladimir Davydov
On 01/14/2014 03:05 AM, Andrew Morton wrote: > On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov > wrote: > >> When reclaiming kmem, we currently don't scan slabs that have less than >> batch_size objects (see shrink_slab_node()): >> >> while (total_scan >= batch_size) { >>

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-13 Thread Andrew Morton
On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov wrote: > When reclaiming kmem, we currently don't scan slabs that have less than > batch_size objects (see shrink_slab_node()): > > while (total_scan >= batch_size) { > shrinkctl->nr_to_scan = batch_size; >

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-13 Thread Andrew Morton
On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov vdavy...@parallels.com wrote: When reclaiming kmem, we currently don't scan slabs that have less than batch_size objects (see shrink_slab_node()): while (total_scan = batch_size) { shrinkctl-nr_to_scan =

Re: [PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-13 Thread Vladimir Davydov
On 01/14/2014 03:05 AM, Andrew Morton wrote: On Sat, 11 Jan 2014 16:36:31 +0400 Vladimir Davydov vdavy...@parallels.com wrote: When reclaiming kmem, we currently don't scan slabs that have less than batch_size objects (see shrink_slab_node()): while (total_scan = batch_size) {

[PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-11 Thread Vladimir Davydov
When reclaiming kmem, we currently don't scan slabs that have less than batch_size objects (see shrink_slab_node()): while (total_scan >= batch_size) { shrinkctl->nr_to_scan = batch_size; shrinker->scan_objects(shrinker, shrinkctl);

[PATCH 1/5] mm: vmscan: shrink all slab objects if tight on memory

2014-01-11 Thread Vladimir Davydov
When reclaiming kmem, we currently don't scan slabs that have less than batch_size objects (see shrink_slab_node()): while (total_scan = batch_size) { shrinkctl-nr_to_scan = batch_size; shrinker-scan_objects(shrinker, shrinkctl); total_scan