Re: [PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-23 Thread Eric W. Biederman
Thomas Graf writes: > On 09/15/14 at 05:35am, Eric Dumazet wrote: >> On Mon, 2014-09-15 at 14:18 +0200, Thomas Graf wrote: >> > As the expansion/shrinking is moved to a worker thread, no allocations >> > will be performed anymore. >> > >> >> You meant : no GFP_ATOMIC allocations ? >> >> I woul

Re: [PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-15 Thread Thomas Graf
On 09/15/14 at 07:49am, Eric Dumazet wrote: > On Mon, 2014-09-15 at 13:49 +0100, Thomas Graf wrote: > > > Agreed. Will introduce this through a table parameter option when > > converting the inet hash table. > > I am not sure you covered the /proc/net/tcp problem yet ? (or inet_diag) I haven't d

Re: [PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-15 Thread Eric Dumazet
On Mon, 2014-09-15 at 13:49 +0100, Thomas Graf wrote: > Agreed. Will introduce this through a table parameter option when > converting the inet hash table. I am not sure you covered the /proc/net/tcp problem yet ? (or inet_diag) -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-15 Thread Thomas Graf
On 09/15/14 at 05:35am, Eric Dumazet wrote: > On Mon, 2014-09-15 at 14:18 +0200, Thomas Graf wrote: > > As the expansion/shrinking is moved to a worker thread, no allocations > > will be performed anymore. > > > > You meant : no GFP_ATOMIC allocations ? > > I would rephrase using something like

Re: [PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-15 Thread Eric Dumazet
On Mon, 2014-09-15 at 14:18 +0200, Thomas Graf wrote: > As the expansion/shrinking is moved to a worker thread, no allocations > will be performed anymore. > You meant : no GFP_ATOMIC allocations ? I would rephrase using something like : Because hash resizes are potentially time consuming, they

[PATCH 1/5] rhashtable: Remove gfp_flags from insert and remove functions

2014-09-15 Thread Thomas Graf
As the expansion/shrinking is moved to a worker thread, no allocations will be performed anymore. Signed-off-by: Thomas Graf --- include/linux/rhashtable.h | 10 +- lib/rhashtable.c | 41 + net/netfilter/nft_hash.c | 4 ++-- net/netlin