Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-19 Thread Daniel Santos
On 09/19/2013 05:35 PM, Daniel Santos wrote: Hmm, I cannot reproduce the error. :( I'm using next-20130919 currently (x86_64), and if I try to just "make O=lib" it fails w/o my patches. The only file that should depend upon error_strings.h is lib/string.c. Ahh! I've never seen the "make

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-19 Thread Daniel Santos
On 09/18/2013 06:38 AM, David Howells wrote: danielfsan...@att.net wrote: This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. I presume you haven't tried building with a

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-19 Thread Daniel Santos
On 09/18/2013 06:38 AM, David Howells wrote: danielfsan...@att.net wrote: This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. I presume you haven't tried building with a make

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-19 Thread Daniel Santos
On 09/19/2013 05:35 PM, Daniel Santos wrote: Hmm, I cannot reproduce the error. :( I'm using next-20130919 currently (x86_64), and if I try to just make O=lib it fails w/o my patches. The only file that should depend upon error_strings.h is lib/string.c. Ahh! I've never seen the make

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread Daniel Santos
On 09/18/2013 06:38 AM, David Howells wrote: danielfsan...@att.net wrote: This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. I presume you haven't tried building with a

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread Daniel Santos
On 09/18/2013 06:55 AM, David Howells wrote: David Howells wrote: (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings) Ah... I see what you're doing. I missed the fact that you don't have a comma after each string. Yeah, I was trying to format the code so that

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread David Howells
David Howells wrote: > (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings) Ah... I see what you're doing. I missed the fact that you don't have a comma after each string. > (3) You are storing a pointer to the symbolic name for each error. On a > 64-bit

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread David Howells
danielfsan...@att.net wrote: > This is a simple bash script that parses our errno*.h files and formats > them into the error_strings.h header that our strerror and strerror_name > functions will use later. I presume you haven't tried building with a "make O=foo" build directory? I see:

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread David Howells
danielfsan...@att.net wrote: This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. I presume you haven't tried building with a make O=foo build directory? I see:

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread David Howells
David Howells dhowe...@redhat.com wrote: (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings) Ah... I see what you're doing. I missed the fact that you don't have a comma after each string. (3) You are storing a pointer to the symbolic name for each error. On a

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread Daniel Santos
On 09/18/2013 06:55 AM, David Howells wrote: David Howells dhowe...@redhat.com wrote: (1) Why are you double-NUL'ing all your strings? (see the \0 in the strings) Ah... I see what you're doing. I missed the fact that you don't have a comma after each string. Yeah, I was trying to

Re: [PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-18 Thread Daniel Santos
On 09/18/2013 06:38 AM, David Howells wrote: danielfsan...@att.net wrote: This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. I presume you haven't tried building with a make

[PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-17 Thread danielfsantos
This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. First it looks at $ARCH and examines the errno.h files and figures out which to use. Then, it parses their error definitions

[PATCH 1/5] scripts: Add mkstrerror.sh

2013-09-17 Thread danielfsantos
This is a simple bash script that parses our errno*.h files and formats them into the error_strings.h header that our strerror and strerror_name functions will use later. First it looks at $ARCH and examines the errno.h files and figures out which to use. Then, it parses their error definitions