On Sat, 17 Apr 2021, David Laight wrote:
> > > In patch 2, vscnprintf should probably be used to make sure it's
> > > 0 terminated.
> >
> > Why? C99 has this[1]:
> >
> > "The vsnprintf function is equivalent to snprintf, with the variable
> > argument list replaced by arg, which shall have
From: Maciej W. Rozycki
> Sent: 16 April 2021 11:49
>
> On Thu, 15 Apr 2021, Joe Perches wrote:
>
> > In patch 2, vscnprintf should probably be used to make sure it's
> > 0 terminated.
>
> Why? C99 has this[1]:
>
> "The vsnprintf function is equivalent to snprintf, with the variable
>
On Fri, 2021-04-16 at 14:41 -0600, Khalid Aziz wrote:
> On 4/15/21 8:08 PM, Joe Perches wrote:
> > And while it's a lot more code, I'd prefer a solution that looks more
> > like the other commonly used kernel logging extension mechanisms
> > where adapter is placed before the format, ... in the
On 4/15/21 8:08 PM, Joe Perches wrote:
> And while it's a lot more code, I'd prefer a solution that looks more
> like the other commonly used kernel logging extension mechanisms
> where adapter is placed before the format, ... in the argument list.
Hi Joe,
I don't mind making these changes. It
On 4/14/21 4:39 PM, Maciej W. Rozycki wrote:
> Update BusLogic driver's messaging system to use `pr_cont' for
> continuation lines, bringing messy output:
>
> pci :00:13.0: PCI->APIC IRQ transform: INT A -> IRQ 17
> scsi: * BusLogic SCSI Driver Version 2.1.17 of 12 September 2013 *
>
On Fri, 2021-04-16 at 16:28 +0200, Maciej W. Rozycki wrote:
> On Fri, 16 Apr 2021, Joe Perches wrote:
>
> > > I'm not sure if that complex message
> > > routing via `blogic_msg' is worth having even, rather than calling
> > > `printk' or suitable variants directly.
> >
> > It's to allow the
On Fri, 16 Apr 2021, Joe Perches wrote:
> > I'm not sure if that complex message
> > routing via `blogic_msg' is worth having even, rather than calling
> > `printk' or suitable variants directly.
>
> It's to allow the message content to be added to the internal
>
On Fri, 2021-04-16 at 12:48 +0200, Maciej W. Rozycki wrote:
> I'm not sure if that complex message
> routing via `blogic_msg' is worth having even, rather than calling
> `printk' or suitable variants directly.
It's to allow the message content to be added to the internal
On Thu, 15 Apr 2021, Joe Perches wrote:
> In patch 2, vscnprintf should probably be used to make sure it's
> 0 terminated.
Why? C99 has this[1]:
"The vsnprintf function is equivalent to snprintf, with the variable
argument list replaced by arg, which shall have been initialized by the
On Thu, 2021-04-15 at 00:39 +0200, Maciej W. Rozycki wrote:
> Update BusLogic driver's messaging system to use `pr_cont' for
> continuation lines, bringing messy output:
>
> pci :00:13.0: PCI->APIC IRQ transform: INT A -> IRQ 17
> scsi: * BusLogic SCSI Driver Version 2.1.17 of 12
Update BusLogic driver's messaging system to use `pr_cont' for
continuation lines, bringing messy output:
pci :00:13.0: PCI->APIC IRQ transform: INT A -> IRQ 17
scsi: * BusLogic SCSI Driver Version 2.1.17 of 12 September 2013 *
scsi: Copyright 1995-1998 by Leonard N. Zubkoff
scsi0:
11 matches
Mail list logo