[PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-26 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-26 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-14 Thread Mark Brown
On Thu, Feb 14, 2008 at 06:10:19PM +0300, Dmitry wrote: > 2008/2/13, Mark Brown <[EMAIL PROTECTED]>: > > +#define WM97XX_ADCSEL_X0x1000 /* x coord measurement */ > > +#define WM97XX_ADCSEL_Y0x2000 /* y coord measurement */ > > +#define WM97XX_ADCSEL_PRES

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-14 Thread Dmitry
Hi, 2008/2/13, Mark Brown <[EMAIL PROTECTED]>: > diff --git a/include/linux/wm97xx.h b/include/linux/wm97xx.h > new file mode 100644 > index 000..f0d9fc0 > --- /dev/null > +++ b/include/linux/wm97xx.h > @@ -0,0 +1,308 @@ ... > +#define WM97XX_POLL0x8000 /* initiate a

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-14 Thread Dmitry
Hi, 2008/2/13, Mark Brown [EMAIL PROTECTED]: diff --git a/include/linux/wm97xx.h b/include/linux/wm97xx.h new file mode 100644 index 000..f0d9fc0 --- /dev/null +++ b/include/linux/wm97xx.h @@ -0,0 +1,308 @@ ... +#define WM97XX_POLL0x8000 /* initiate a polling

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-14 Thread Mark Brown
On Thu, Feb 14, 2008 at 06:10:19PM +0300, Dmitry wrote: 2008/2/13, Mark Brown [EMAIL PROTECTED]: +#define WM97XX_ADCSEL_X0x1000 /* x coord measurement */ +#define WM97XX_ADCSEL_Y0x2000 /* y coord measurement */ +#define WM97XX_ADCSEL_PRES 0x3000 /*

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Dmitry
Hi, 2008/2/13, Mark Brown <[EMAIL PROTECTED]>: > On Tue, Feb 12, 2008 at 10:58:50PM +, Dmitry Baryshkov wrote: > > > You used platform_device_register, but should be using platform_device_add, > > otherwise you get barfs with 2.6.25-rc1 (device is initialized twice). Also > > Thanks for that.

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
On Tue, Feb 12, 2008 at 10:58:50PM +, Dmitry Baryshkov wrote: > You used platform_device_register, but should be using platform_device_add, > otherwise you get barfs with 2.6.25-rc1 (device is initialized twice). Also Thanks for that. I feel like I should knock up a patch to clarify the

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
On Tue, Feb 12, 2008 at 11:28:43PM -0500, Pete MacKay wrote: > We're using the wm9712 codec with the sound/soc/pxa code configured in and > came across this build error: Which kernel version are you building against? I've been testing with v2.6.24 (and have just updated to v2.6.25-rc1 which is

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
On Tue, Feb 12, 2008 at 11:28:43PM -0500, Pete MacKay wrote: We're using the wm9712 codec with the sound/soc/pxa code configured in and came across this build error: Which kernel version are you building against? I've been testing with v2.6.24 (and have just updated to v2.6.25-rc1 which is

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
On Tue, Feb 12, 2008 at 10:58:50PM +, Dmitry Baryshkov wrote: You used platform_device_register, but should be using platform_device_add, otherwise you get barfs with 2.6.25-rc1 (device is initialized twice). Also Thanks for that. I feel like I should knock up a patch to clarify the

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Dmitry
Hi, 2008/2/13, Mark Brown [EMAIL PROTECTED]: On Tue, Feb 12, 2008 at 10:58:50PM +, Dmitry Baryshkov wrote: You used platform_device_register, but should be using platform_device_add, otherwise you get barfs with 2.6.25-rc1 (device is initialized twice). Also Thanks for that. I feel

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-13 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-12 Thread Pete MacKay
> This patch series adds support for the touchscreen controllers provided > by Wolfson Microelectronics WM97xx series chips in both polled and > streaming modes. We're using the wm9712 codec with the sound/soc/pxa code configured in and came across this build error: In file included from

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-12 Thread Dmitry Baryshkov
Hi, Mark Brown wrote: > This patch series adds support for the touchscreen controllers provided > by Wolfson Microelectronics WM97xx series chips in both polled and > streaming modes. You used platform_device_register, but should be using platform_device_add, otherwise you get barfs with

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-12 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-12 Thread Pete MacKay
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. We're using the wm9712 codec with the sound/soc/pxa code configured in and came across this build error: In file included from

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-12 Thread Dmitry Baryshkov
Hi, Mark Brown wrote: This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. You used platform_device_register, but should be using platform_device_add, otherwise you get barfs with

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-08 Thread Mark Brown
On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote: > The probe error handling is not quite correct. When we reach the fragment > above ret variable is 0 so if platfrom_device_alloc() fails we will return > 0 and the device will be considered bound but in half-dead state. Please >

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-08 Thread Mark Brown
On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote: The probe error handling is not quite correct. When we reach the fragment above ret variable is 0 so if platfrom_device_alloc() fails we will return 0 and the device will be considered bound but in half-dead state. Please make

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-07 Thread Dmitry Torokhov
Hi Mark, On Sat, Jan 26, 2008 at 05:28:31PM +, Mark Brown wrote: > + > + /* register our battery device */ > + wm->battery_dev = platform_device_alloc("wm97xx-battery", 0); > + if (!wm->battery_dev) > + goto batt_err; ... > + batt_err: > +

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-07 Thread Dmitry Torokhov
Hi Mark, On Sat, Jan 26, 2008 at 05:28:31PM +, Mark Brown wrote: + + /* register our battery device */ + wm-battery_dev = platform_device_alloc(wm97xx-battery, 0); + if (!wm-battery_dev) + goto batt_err; ... + batt_err: +

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry
2008/1/26, Mark Brown <[EMAIL PROTECTED]>: > On Sat, Jan 26, 2008 at 10:18:16AM +, Dmitry Baryshkov wrote: > > > Please apply this patch. > > Done, thanks. > > > BTW: Could you please also add me to the "CC" list > > of this patch serie? > > Sure. > Thanks! -- With

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Mark Brown
On Sat, Jan 26, 2008 at 10:18:16AM +, Dmitry Baryshkov wrote: > Please apply this patch. Done, thanks. > BTW: Could you please also add me to the "CC" list > of this patch serie? Sure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry Baryshkov
Hi, Please apply this patch. BTW: Could you please also add me to the "CC" list of this patch serie? >From 1e61dd8a8c8346f925f09cae34275c9754bf2be1 Mon Sep 17 00:00:00 2001 From: Dmitry Baryshkov <[EMAIL PROTECTED]> Date: Sat, 26 Jan 2008 13:04:29 +0300 Subject: [PATCH] Fix wm97xx_resume

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry Baryshkov
Hi, Mark Brown wrote: > +#ifdef CONFIG_PM > +int wm97xx_resume(struct device *dev) > +{ > + struct wm97xx *wm = dev_get_drvdata(dev); > + > + /* restore digitiser and gpios */ > + if (wm->id == WM9713_ID2) { > + wm97xx_reg_write(wm, AC97_WM9713_DIG1, wm->dig[0]); > +

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry Baryshkov
Hi, Please apply this patch. BTW: Could you please also add me to the CC list of this patch serie? From 1e61dd8a8c8346f925f09cae34275c9754bf2be1 Mon Sep 17 00:00:00 2001 From: Dmitry Baryshkov [EMAIL PROTECTED] Date: Sat, 26 Jan 2008 13:04:29 +0300 Subject: [PATCH] Fix wm97xx_resume

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry Baryshkov
Hi, Mark Brown wrote: +#ifdef CONFIG_PM +int wm97xx_resume(struct device *dev) +{ + struct wm97xx *wm = dev_get_drvdata(dev); + + /* restore digitiser and gpios */ + if (wm-id == WM9713_ID2) { + wm97xx_reg_write(wm, AC97_WM9713_DIG1, wm-dig[0]); +

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Mark Brown
On Sat, Jan 26, 2008 at 10:18:16AM +, Dmitry Baryshkov wrote: Please apply this patch. Done, thanks. BTW: Could you please also add me to the CC list of this patch serie? Sure. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Dmitry
2008/1/26, Mark Brown [EMAIL PROTECTED]: On Sat, Jan 26, 2008 at 10:18:16AM +, Dmitry Baryshkov wrote: Please apply this patch. Done, thanks. BTW: Could you please also add me to the CC list of this patch serie? Sure. Thanks! -- With best wishes

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-26 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-21 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-21 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-10 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number

[PATCH 1/6] Core driver for WM97xx touchscreens

2008-01-10 Thread Mark Brown
This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. These drivers have been maintained out of tree since 2003. During that time the driver the primary maintainer was Liam Girdwood and a number