Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-08 Thread Viresh Kumar
On 9 August 2013 00:20, Stephen Warren wrote: > I don't think so. I think it's reasonable to have a per-SoC cpufreq > driver whose primary content is the parameterization data and/or custom > hooks for a unified core cpufreq driver. The duplicate parts of each > cpufreq driver can be moved into

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-08 Thread Stephen Warren
On 08/07/2013 08:42 PM, Viresh Kumar wrote: > On 8 August 2013 00:20, Stephen Warren wrote: >> Right, and that's *exactly* what having a cpufreq driver is for; to >> implement the details of CPU clock management. > > cpufreq drivers used to keep such information since a long time, > probably

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-08 Thread Stephen Warren
On 08/07/2013 08:42 PM, Viresh Kumar wrote: On 8 August 2013 00:20, Stephen Warren swar...@wwwdotorg.org wrote: Right, and that's *exactly* what having a cpufreq driver is for; to implement the details of CPU clock management. cpufreq drivers used to keep such information since a long time,

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-08 Thread Viresh Kumar
On 9 August 2013 00:20, Stephen Warren swar...@wwwdotorg.org wrote: I don't think so. I think it's reasonable to have a per-SoC cpufreq driver whose primary content is the parameterization data and/or custom hooks for a unified core cpufreq driver. The duplicate parts of each cpufreq driver

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 8 August 2013 00:20, Stephen Warren wrote: > Right, and that's *exactly* what having a cpufreq driver is for; to > implement the details of CPU clock management. cpufreq drivers used to keep such information since a long time, probably because there wasn't another place to keep them and

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 11:54 AM, Viresh Kumar wrote: > On 7 August 2013 23:18, Stephen Warren wrote: >> On 08/07/2013 11:45 AM, Viresh Kumar wrote: >>> On 7 August 2013 23:08, Stephen Warren wrote: On 08/07/2013 08:46 AM, Viresh Kumar wrote: > This patch adds CPU0's clk driver for Tegra. It will

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 7 August 2013 23:18, Stephen Warren wrote: > On 08/07/2013 11:45 AM, Viresh Kumar wrote: >> On 7 August 2013 23:08, Stephen Warren wrote: >>> On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 11:45 AM, Viresh Kumar wrote: > On 7 August 2013 23:08, Stephen Warren wrote: >> On 08/07/2013 08:46 AM, Viresh Kumar wrote: >>> This patch adds CPU0's clk driver for Tegra. It will be used by the generic >>> cpufreq-cpu0 driver to get/set cpu clk. >>> >>> Most of the platform

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 7 August 2013 23:08, Stephen Warren wrote: > On 08/07/2013 08:46 AM, Viresh Kumar wrote: >> This patch adds CPU0's clk driver for Tegra. It will be used by the generic >> cpufreq-cpu0 driver to get/set cpu clk. >> >> Most of the platform specific bits are picked from tegra-cpufreq.c. > > Hmmm.

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 08:46 AM, Viresh Kumar wrote: > This patch adds CPU0's clk driver for Tegra. It will be used by the generic > cpufreq-cpu0 driver to get/set cpu clk. > > Most of the platform specific bits are picked from tegra-cpufreq.c. Hmmm. I'm not sure if it makes sense to represent this as a

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Mike Turquette
Quoting Viresh Kumar (2013-08-07 07:46:43) > This patch adds CPU0's clk driver for Tegra. It will be used by the generic > cpufreq-cpu0 driver to get/set cpu clk. > > Most of the platform specific bits are picked from tegra-cpufreq.c. > > Signed-off-by: Viresh Kumar Hi Viresh, It is nice to

[PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform specific bits are picked from tegra-cpufreq.c. Signed-off-by: Viresh Kumar --- drivers/clk/tegra/Makefile | 1 + drivers/clk/tegra/clk-cpu.c | 164

[PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform specific bits are picked from tegra-cpufreq.c. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/clk/tegra/Makefile | 1 +

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Mike Turquette
Quoting Viresh Kumar (2013-08-07 07:46:43) This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform specific bits are picked from tegra-cpufreq.c. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Hi Viresh,

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform specific bits are picked from tegra-cpufreq.c. Hmmm. I'm not sure if it makes sense to represent this as a

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform specific bits are picked from

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 11:45 AM, Viresh Kumar wrote: On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's clk driver for Tegra. It will be used by the generic cpufreq-cpu0 driver to get/set cpu clk. Most of the platform

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 7 August 2013 23:18, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 11:45 AM, Viresh Kumar wrote: On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's clk driver for Tegra. It will be used by the

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Stephen Warren
On 08/07/2013 11:54 AM, Viresh Kumar wrote: On 7 August 2013 23:18, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 11:45 AM, Viresh Kumar wrote: On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote: On 08/07/2013 08:46 AM, Viresh Kumar wrote: This patch adds CPU0's

Re: [PATCH 1/6] clk: Tegra: Add CPU0 clock driver

2013-08-07 Thread Viresh Kumar
On 8 August 2013 00:20, Stephen Warren swar...@wwwdotorg.org wrote: Right, and that's *exactly* what having a cpufreq driver is for; to implement the details of CPU clock management. cpufreq drivers used to keep such information since a long time, probably because there wasn't another place to