Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Ben Collins wrote: > On Fri, 2007-05-25 at 16:28 -0700, H. Peter Anvin wrote: >> Jesse Barnes wrote: >>> But how often do you have to debug bootloader or compressed boot code? In >>> fact, most debug output like this isn't very useful after some initial >>> debugging, so we usually take it out.

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Ben Collins
On Fri, 2007-05-25 at 16:28 -0700, H. Peter Anvin wrote: > Jesse Barnes wrote: > > > > But how often do you have to debug bootloader or compressed boot code? In > > fact, most debug output like this isn't very useful after some initial > > debugging, so we usually take it out. I'm not sure why

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 4:43:41 H. Peter Anvin wrote: > Jesse Barnes wrote: > > Right, but you're special that way. And moreover, you would know how to > > add such debug statements as needed. But is this output something we > > really need enabled unconditionally for everyone? > > *I* can do tha

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Jesse Barnes wrote: > > Right, but you're special that way. And moreover, you would know how to add > such debug statements as needed. But is this output something we really need > enabled unconditionally for everyone? > *I* can do that, yes, but I usually don't have access to the platform i

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 4:28:18 H. Peter Anvin wrote: > Jesse Barnes wrote: > > But how often do you have to debug bootloader or compressed boot code? > > In fact, most debug output like this isn't very useful after some initial > > debugging, so we usually take it out. I'm not sure why this woul

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Jesse Barnes wrote: > > But how often do you have to debug bootloader or compressed boot code? In > fact, most debug output like this isn't very useful after some initial > debugging, so we usually take it out. I'm not sure why this would be any > different... > You're asking me this? I ge

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Jesse Barnes
On Friday, May 25, 2007 12:45:40 H. Peter Anvin wrote: > Ben Collins wrote: > > On Fri, 2007-05-25 at 13:33 +0200, Andi Kleen wrote: > >> Ben Collins <[EMAIL PROTECTED]> writes: > >> > >> Why? > > > > Because there's no other way to make the kernel totally quiet. We've > > been patching this out so

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread H. Peter Anvin
Ben Collins wrote: > On Fri, 2007-05-25 at 13:33 +0200, Andi Kleen wrote: >> Ben Collins <[EMAIL PROTECTED]> writes: >> >> Why? > > Because there's no other way to make the kernel totally quiet. We've > been patching this out so that the boot sequence has that "clean look". > > Other than that,

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Ben Collins
On Fri, 2007-05-25 at 13:33 +0200, Andi Kleen wrote: > Ben Collins <[EMAIL PROTECTED]> writes: > > Why? Because there's no other way to make the kernel totally quiet. We've been patching this out so that the boot sequence has that "clean look". Other than that, it's useless :) -- Ubuntu : h

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-25 Thread Andi Kleen
Ben Collins <[EMAIL PROTECTED]> writes: Why? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper (fixed)

2007-05-24 Thread Andrew Morton
On Wed, 23 May 2007 17:59:10 -0400 Ben Collins <[EMAIL PROTECTED]> wrote: > Updated to include proper spacing for putstr() macro. > > Signed-off-by: Ben Collins <[EMAIL PROTECTED]> > --- > arch/i386/Kconfig.debug|6 ++ > arch/i386/boot/compressed/misc.c |8 +--- > a

Re: [PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-23 Thread Randy Dunlap
On Wed, 23 May 2007 17:59:10 -0400 Ben Collins wrote: > diff --git a/arch/i386/boot/compressed/misc.c > b/arch/i386/boot/compressed/misc.c > index b28505c..cc630d5 100644 > --- a/arch/i386/boot/compressed/misc.c > +++ b/arch/i386/boot/compressed/misc.c > @@ -278,6 +277,9 @@ static void putstr(con

[PATCH 1/6] i386/x86_64: Allow disabling the putstr's from compressed boot wrapper

2007-05-23 Thread Ben Collins
Signed-off-by: Ben Collins <[EMAIL PROTECTED]> --- arch/i386/Kconfig.debug|6 ++ arch/i386/boot/compressed/misc.c |8 +--- arch/x86_64/Kconfig.debug |6 ++ arch/x86_64/boot/compressed/misc.c |8 +--- 4 files changed, 22 insertions(+), 6 deleti