Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-23 Thread Jonathan Cameron
On 22/05/15 05:19, Kevin Tsai wrote: > - Renamed company name. > - Removed cm32181_reg. > - Removed white space. > - Removed unused include files. > - Updated macro definitions. > - Renamed cm32181_chip pointer to chip. > > Signed-off-by: Kevin Tsai Obviously this whole series needs better

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-23 Thread Jonathan Cameron
On 22/05/15 05:19, Kevin Tsai wrote: - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to chip. Signed-off-by: Kevin Tsai kt...@capellamicro.com Obviously this whole series

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-22 Thread Daniel Baluta
On Fri, May 22, 2015 at 4:56 AM, Greg KH wrote: > On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote: >> Signed-off-by: Kevin Tsai >> --- > > Your whole changelog ended up in the Subject line :( Hi Kevin, Few comments: 1) Please also add a cover letter. Use --cover-letter parameter of

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-22 Thread Daniel Baluta
On Fri, May 22, 2015 at 4:56 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote: Signed-off-by: Kevin Tsai kt...@capellamicro.com --- Your whole changelog ended up in the Subject line :( Hi Kevin, Few comments: 1) Please also add a

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Joe Perches
(meh, bad mousing sent the first reply too soon) It'd also be better if this series had a cover letter so that could be replied to and added as a merge header instead of having to ack/nack individual patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Joe Perches
On Thu, 2015-05-21 at 21:19 -0700, Kevin Tsai wrote: > - Renamed company name. > - Removed cm32181_reg. > - Removed white space. > - Removed unused include files. > - Updated macro definitions. > - Renamed cm32181_chip pointer to chip. Hi Kevin, Please don't use the same title for multiple

[PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Kevin Tsai
- Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to chip. Signed-off-by: Kevin Tsai --- drivers/iio/light/Kconfig | 4 +- drivers/iio/light/cm32181.c | 126

RE: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-21 Thread Kevin Tsai
-...@vger.kernel.org Subject: Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to ch On Thu, May 21, 2015 at 05:30

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-21 Thread Greg KH
On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote: > Signed-off-by: Kevin Tsai > --- Your whole changelog ended up in the Subject line :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macr

2015-05-21 Thread Kevin Tsai
Signed-off-by: Kevin Tsai --- Renamed company name. Removed cm32181_reg. Removed white space. Removed unused include files. Updated macro definitions. Renamed cm32181_chip pointer to chip. drivers/iio/light/Kconfig | 4 +- drivers/iio/light/cm32181.c | 126

[PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macr

2015-05-21 Thread Kevin Tsai
Signed-off-by: Kevin Tsai kt...@capellamicro.com --- Renamed company name. Removed cm32181_reg. Removed white space. Removed unused include files. Updated macro definitions. Renamed cm32181_chip pointer to chip. drivers/iio/light/Kconfig | 4 +- drivers/iio/light/cm32181.c | 126

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-21 Thread Greg KH
On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote: Signed-off-by: Kevin Tsai kt...@capellamicro.com --- Your whole changelog ended up in the Subject line :( -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Joe Perches
On Thu, 2015-05-21 at 21:19 -0700, Kevin Tsai wrote: - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to chip. Hi Kevin, Please don't use the same title for multiple patches.

RE: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated

2015-05-21 Thread Kevin Tsai
-...@vger.kernel.org Subject: Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to ch On Thu, May 21, 2015 at 05:30

[PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Kevin Tsai
- Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to chip. Signed-off-by: Kevin Tsai kt...@capellamicro.com --- drivers/iio/light/Kconfig | 4 +- drivers/iio/light/cm32181.c | 126

Re: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver.

2015-05-21 Thread Joe Perches
(meh, bad mousing sent the first reply too soon) It'd also be better if this series had a cover letter so that could be replied to and added as a merge header instead of having to ack/nack individual patches. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of