On Mon, Mar 22, 2021 at 8:54 PM Li, Aubrey wrote:
>
> On 2021/3/22 20:56, Peter Zijlstra wrote:
> > On Mon, Mar 22, 2021 at 08:31:09PM +0800, Li, Aubrey wrote:
> >> Please let me know if I put cookie match check at the right position
> >> in task_hot(), if so, I'll obtain some performance data of
On 2021/3/22 20:56, Peter Zijlstra wrote:
> On Mon, Mar 22, 2021 at 08:31:09PM +0800, Li, Aubrey wrote:
>> Please let me know if I put cookie match check at the right position
>> in task_hot(), if so, I'll obtain some performance data of it.
>>
>> Thanks,
>> -Aubrey
>>
>> ==
On 2021/3/22 20:56, Peter Zijlstra wrote:
> On Mon, Mar 22, 2021 at 08:31:09PM +0800, Li, Aubrey wrote:
>> Please let me know if I put cookie match check at the right position
>> in task_hot(), if so, I'll obtain some performance data of it.
>>
>> Thanks,
>> -Aubrey
>>
>> ==
On Mon, Mar 22, 2021 at 08:31:09PM +0800, Li, Aubrey wrote:
> Please let me know if I put cookie match check at the right position
> in task_hot(), if so, I'll obtain some performance data of it.
>
> Thanks,
> -Aubrey
>
> ===
> diff --git a/kern
On 2021/3/22 16:57, Peter Zijlstra wrote:
>
>> Do you have any suggestions before we drop it?
>
> Yeah, how about you make it part of task_hot() ? Have task_hot() refuse
> migration it the cookie doesn't match.
>
> task_hot() is a hint and will get ignored when appropriate.
>
Please let me kn
On Mon, Mar 22, 2021 at 04:12:17PM +0800, Li, Aubrey wrote:
> > But suppose there is an imbalance; then this cookie crud can forever
> > stall balance.
> >
> > Imagine this cpu running a while(1); with a uniqie cookie on, then it
> > will _never_ accept other tasks == BAD.
> >
>
> How about put
On 2021/3/22 15:48, Peter Zijlstra wrote:
> On Sun, Mar 21, 2021 at 09:34:00PM +0800, Li, Aubrey wrote:
>> Hi Peter,
>>
>> On 2021/3/20 23:34, Peter Zijlstra wrote:
>>> On Fri, Mar 19, 2021 at 04:32:48PM -0400, Joel Fernandes (Google) wrote:
@@ -7530,8 +7543,9 @@ int can_migrate_task(struct ta
On Sun, Mar 21, 2021 at 09:34:00PM +0800, Li, Aubrey wrote:
> Hi Peter,
>
> On 2021/3/20 23:34, Peter Zijlstra wrote:
> > On Fri, Mar 19, 2021 at 04:32:48PM -0400, Joel Fernandes (Google) wrote:
> >> @@ -7530,8 +7543,9 @@ int can_migrate_task(struct task_struct *p, struct
> >> lb_env *env)
> >>
Hi Peter,
On 2021/3/20 23:34, Peter Zijlstra wrote:
> On Fri, Mar 19, 2021 at 04:32:48PM -0400, Joel Fernandes (Google) wrote:
>> @@ -7530,8 +7543,9 @@ int can_migrate_task(struct task_struct *p, struct
>> lb_env *env)
>> * We do not migrate tasks that are:
>> * 1) throttled_lb_pair,
On Fri, Mar 19, 2021 at 04:32:48PM -0400, Joel Fernandes (Google) wrote:
> @@ -7530,8 +7543,9 @@ int can_migrate_task(struct task_struct *p, struct
> lb_env *env)
>* We do not migrate tasks that are:
>* 1) throttled_lb_pair, or
>* 2) cannot be migrated to this CPU due to cp
From: Aubrey Li
- Don't migrate if there is a cookie mismatch
Load balance tries to move task from busiest CPU to the
destination CPU. When core scheduling is enabled, if the
task's cookie does not match with the destination CPU's
core cookie, this task will be skipped by thi
11 matches
Mail list logo
