Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Pekka Enberg
On 12/19/2013 11:26 AM, Vasily Averin wrote: On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 13:26:12, Vasily Averin wrote: > On 12/19/2013 12:39 PM, Vladimir Davydov wrote: > > On 12/19/2013 12:17 PM, Vasily Averin wrote: > >> On 12/18/2013 05:16 PM, Vladimir Davydov wrote: > >>> --- a/mm/slab_common.c > >>> +++ b/mm/slab_common.c > >>> @@ -176,8 +176,9 @@

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 01:26 PM, Vasily Averin wrote: > On 12/19/2013 12:39 PM, Vladimir Davydov wrote: >> On 12/19/2013 12:17 PM, Vasily Averin wrote: >>> On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
On 12/19/2013 12:39 PM, Vladimir Davydov wrote: > On 12/19/2013 12:17 PM, Vasily Averin wrote: >> On 12/18/2013 05:16 PM, Vladimir Davydov wrote: >>> --- a/mm/slab_common.c >>> +++ b/mm/slab_common.c >>> @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const >>> char *name,

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 12:51:38, Vladimir Davydov wrote: > On 12/19/2013 12:44 PM, Michal Hocko wrote: > > On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: > >> On 12/18/2013 08:56 PM, Michal Hocko wrote: > >>> On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: > Signed-off-by: Vladimir Davydov >

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
On 12/18/2013 05:16 PM, Vladimir Davydov wrote: > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const > char *name, size_t size, > get_online_cpus(); > mutex_lock(_mutex); > > - if

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 12:44 PM, Michal Hocko wrote: > On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: >> On 12/18/2013 08:56 PM, Michal Hocko wrote: >>> On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov Cc: Michal Hocko Cc: Johannes Weiner Cc:

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: > On 12/18/2013 08:56 PM, Michal Hocko wrote: > > On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: > >> Signed-off-by: Vladimir Davydov > >> Cc: Michal Hocko > >> Cc: Johannes Weiner > >> Cc: Glauber Costa > >> Cc: Christoph Lameter > >> Cc:

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 12:17 PM, Vasily Averin wrote: > On 12/18/2013 05:16 PM, Vladimir Davydov wrote: >> --- a/mm/slab_common.c >> +++ b/mm/slab_common.c >> @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const >> char *name, size_t size, >> get_online_cpus(); >>

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const char *name, size_t size, get_online_cpus();

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: On 12/18/2013 08:56 PM, Michal Hocko wrote: On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 12:44 PM, Michal Hocko wrote: On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: On 12/18/2013 08:56 PM, Michal Hocko wrote: On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const char *name, size_t size, get_online_cpus(); mutex_lock(slab_mutex); - if

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 12:51:38, Vladimir Davydov wrote: On 12/19/2013 12:44 PM, Michal Hocko wrote: On Thu 19-12-13 10:31:43, Vladimir Davydov wrote: On 12/18/2013 08:56 PM, Michal Hocko wrote: On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const char *name, size_t size,

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vladimir Davydov
On 12/19/2013 01:26 PM, Vasily Averin wrote: On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Michal Hocko
On Thu 19-12-13 13:26:12, Vasily Averin wrote: On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Pekka Enberg
On 12/19/2013 11:26 AM, Vasily Averin wrote: On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Pekka Enberg
On 12/18/2013 03:16 PM, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov Cc: Michal Hocko Cc: Johannes Weiner Cc: Glauber Costa Cc: Christoph Lameter Cc: Pekka Enberg Cc: Andrew Morton Look good to me. Even though this patch just touches slab, I think it should go through the

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Vladimir Davydov
On 12/18/2013 08:56 PM, Michal Hocko wrote: > On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: >> Signed-off-by: Vladimir Davydov >> Cc: Michal Hocko >> Cc: Johannes Weiner >> Cc: Glauber Costa >> Cc: Christoph Lameter >> Cc: Pekka Enberg >> Cc: Andrew Morton > Dunno, is this really better

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Michal Hocko
On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: > Signed-off-by: Vladimir Davydov > Cc: Michal Hocko > Cc: Johannes Weiner > Cc: Glauber Costa > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: Andrew Morton Dunno, is this really better to be worth the code churn? It even makes the

[PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Vladimir Davydov
Signed-off-by: Vladimir Davydov Cc: Michal Hocko Cc: Johannes Weiner Cc: Glauber Costa Cc: Christoph Lameter Cc: Pekka Enberg Cc: Andrew Morton --- mm/slab_common.c | 66 +++--- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git

[PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Vladimir Davydov
Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa glom...@gmail.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc: Andrew Morton a...@linux-foundation.org ---

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Michal Hocko
On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa glom...@gmail.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc:

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Vladimir Davydov
On 12/18/2013 08:56 PM, Michal Hocko wrote: On Wed 18-12-13 17:16:52, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa glom...@gmail.com Cc: Christoph Lameter c...@linux.com

Re: [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-18 Thread Pekka Enberg
On 12/18/2013 03:16 PM, Vladimir Davydov wrote: Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Johannes Weiner han...@cmpxchg.org Cc: Glauber Costa glom...@gmail.com Cc: Christoph Lameter c...@linux.com Cc: Pekka Enberg penb...@kernel.org Cc: Andrew