Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Greg Kroah-Hartman
On Fri, Jan 22, 2021 at 08:33:33AM +0100, Jiri Slaby wrote: > On 21. 01. 21, 19:42, Linus Torvalds wrote: > > On Thu, Jan 21, 2021 at 9:57 AM Greg Kroah-Hartman > > wrote: > > > > > > Incremental patches please as these are already in my public branches > > > and I would have to revert them and

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Jiri Slaby
On 21. 01. 21, 19:42, Linus Torvalds wrote: On Thu, Jan 21, 2021 at 9:57 AM Greg Kroah-Hartman wrote: Incremental patches please as these are already in my public branches and I would have to revert them and add new ones but that's messy, so fixes on top is fine. Ok. And since I think you

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Jiri Slaby
On 21. 01. 21, 22:09, Linus Torvalds wrote: On Thu, Jan 21, 2021 at 11:43 AM Greg Kroah-Hartman wrote: This works, thanks for these. I'll wait for Jiri to review them before applying them to my branches... Let's hope Jiri sees them, since he had some email issue earlier.. I'll add his

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Linus Torvalds
On Thu, Jan 21, 2021 at 11:43 AM Greg Kroah-Hartman wrote: > > This works, thanks for these. I'll wait for Jiri to review them before > applying them to my branches... Let's hope Jiri sees them, since he had some email issue earlier.. I'll add his suse address here too. Linus

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Greg Kroah-Hartman
On Thu, Jan 21, 2021 at 10:42:04AM -0800, Linus Torvalds wrote: > On Thu, Jan 21, 2021 at 9:57 AM Greg Kroah-Hartman > wrote: > > > > Incremental patches please as these are already in my public branches > > and I would have to revert them and add new ones but that's messy, so > > fixes on top is

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Linus Torvalds
On Thu, Jan 21, 2021 at 9:57 AM Greg Kroah-Hartman wrote: > > Incremental patches please as these are already in my public branches > and I would have to revert them and add new ones but that's messy, so > fixes on top is fine. Ok. And since I think you put that first tty_write conversion patch

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Greg Kroah-Hartman
On Thu, Jan 21, 2021 at 09:44:17AM -0800, Linus Torvalds wrote: > On Thu, Jan 21, 2021 at 1:40 AM Jiri Slaby wrote: > > > > Ok, here belongs my earlier note: "if ld == NULL => crash here." That is > > if hangup happens during the ldisc wait, the kernel will crash in > > tty_ldisc_deref. > >

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Linus Torvalds
On Thu, Jan 21, 2021 at 1:40 AM Jiri Slaby wrote: > > Ok, here belongs my earlier note: "if ld == NULL => crash here." That is > if hangup happens during the ldisc wait, the kernel will crash in > tty_ldisc_deref. Right you are, good catch. > Is there a reason not to convert hung_up_tty_fops

Re: [PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Jiri Slaby
On 21. 01. 21, 10:00, Greg Kroah-Hartman wrote: From: Linus Torvalds This makes the tty layer use the .write_iter() function instead of the traditional .write() functionality. That allows writev(), but more importantly also makes it possible to enable .splice_write() for ttys, reinstating the

[PATCH 1/6] tty: implement write_iter

2021-01-21 Thread Greg Kroah-Hartman
From: Linus Torvalds This makes the tty layer use the .write_iter() function instead of the traditional .write() functionality. That allows writev(), but more importantly also makes it possible to enable .splice_write() for ttys, reinstating the "splice to tty" functionality that was lost in