Re: [PATCH 1/7] drm/komeda: Add d71_enum_resources and d71_cleanup

2019-01-09 Thread james qian wang (Arm Technology China)
On 2019/1/7, 9:41 PM, "Brian Starkey" wrote: Hi James, A few minor comments. On Mon, Dec 24, 2018 at 08:58:46AM +, james qian wang (Arm Technology China) wrote: > D71 consists of a number of Register Blocks, every Block controls a > specific HW function,

Re: [PATCH 1/7] drm/komeda: Add d71_enum_resources and d71_cleanup

2019-01-07 Thread Brian Starkey
Hi James, A few minor comments. On Mon, Dec 24, 2018 at 08:58:46AM +, james qian wang (Arm Technology China) wrote: > D71 consists of a number of Register Blocks, every Block controls a > specific HW function, every block has a common block_header to represent > its type and pipeline

[PATCH 1/7] drm/komeda: Add d71_enum_resources and d71_cleanup

2018-12-24 Thread james qian wang (Arm Technology China)
D71 consists of a number of Register Blocks, every Block controls a specific HW function, every block has a common block_header to represent its type and pipeline information. GCU (Global Control Unit) is the first Block which describe the global information of D71 HW, Like number of block