Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-05-02 Thread Johan Hovold
On Sun, Apr 29, 2018 at 03:35:11PM +0200, Greg Kroah-Hartman wrote: > I'll wait for the next resend of this series to review it again and > consider merging it. Thanks, I'll send a v2 sometime next week. Johan

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-05-02 Thread Johan Hovold
On Sun, Apr 29, 2018 at 03:35:11PM +0200, Greg Kroah-Hartman wrote: > I'll wait for the next resend of this series to review it again and > consider merging it. Thanks, I'll send a v2 sometime next week. Johan

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-29 Thread Greg Kroah-Hartman
On Wed, Apr 25, 2018 at 02:23:15PM +0200, Johan Hovold wrote: > On Wed, Apr 25, 2018 at 12:56:45PM +0200, Johan Hovold wrote: > > On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > > > > +static int

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-29 Thread Greg Kroah-Hartman
On Wed, Apr 25, 2018 at 02:23:15PM +0200, Johan Hovold wrote: > On Wed, Apr 25, 2018 at 12:56:45PM +0200, Johan Hovold wrote: > > On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > > > > +static int

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Johan Hovold
On Wed, Apr 25, 2018 at 12:56:45PM +0200, Johan Hovold wrote: > On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > > +static int gnss_open(struct inode *inode, struct file *file) > > > +{ > > > + struct

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Johan Hovold
On Wed, Apr 25, 2018 at 12:56:45PM +0200, Johan Hovold wrote: > On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > > +static int gnss_open(struct inode *inode, struct file *file) > > > +{ > > > + struct

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Johan Hovold
On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > +#define GNSS_MINORS16 > > Why only 16? Just have to start somewhere? Yeah, a mostly arbitrarily picked number. I figured only developers would have an

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Johan Hovold
On Wed, Apr 25, 2018 at 10:56:49AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > > +#define GNSS_MINORS16 > > Why only 16? Just have to start somewhere? Yeah, a mostly arbitrarily picked number. I figured only developers would have an

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > +#define GNSS_MINORS 16 Why only 16? Just have to start somewhere? > +static DEFINE_IDA(gnss_minors); > +static dev_t gnss_first; > + > +/* FIFO size must be a power of two */ > +#define GNSS_READ_FIFO_SIZE 4096 > +#define

Re: [PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-25 Thread Greg Kroah-Hartman
On Tue, Apr 24, 2018 at 06:34:52PM +0200, Johan Hovold wrote: > +#define GNSS_MINORS 16 Why only 16? Just have to start somewhere? > +static DEFINE_IDA(gnss_minors); > +static dev_t gnss_first; > + > +/* FIFO size must be a power of two */ > +#define GNSS_READ_FIFO_SIZE 4096 > +#define

[PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-24 Thread Johan Hovold
Add a new subsystem for GNSS (e.g. GPS) receivers. While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging (rpmsg). The new GNSS

[PATCH 1/7] gnss: add GNSS receiver subsystem

2018-04-24 Thread Johan Hovold
Add a new subsystem for GNSS (e.g. GPS) receivers. While GNSS receivers are typically accessed using a UART interface they often also support other I/O interfaces such as I2C, SPI and USB, while yet other devices use iomem or even some form of remote-processor messaging (rpmsg). The new GNSS