Re: [PATCH 1/7] intel-speed-select: Add int argument to command functions

2019-09-30 Thread Srinivas Pandruvada
On Mon, 2019-09-30 at 11:18 -0400, Prarit Bhargava wrote: > > On 9/26/19 4:21 PM, Srinivas Pandruvada wrote: > > On Thu, 2019-09-26 at 08:54 -0400, Prarit Bhargava wrote: > > > The current code structure has similar but separate command > > > functions > > > for > > > the enable and disable

Re: [PATCH 1/7] intel-speed-select: Add int argument to command functions

2019-09-30 Thread Prarit Bhargava
On 9/26/19 4:21 PM, Srinivas Pandruvada wrote: > On Thu, 2019-09-26 at 08:54 -0400, Prarit Bhargava wrote: >> The current code structure has similar but separate command functions >> for >> the enable and disable operations. This can be improved by adding an >> int >> argument to the command

Re: [PATCH 1/7] intel-speed-select: Add int argument to command functions

2019-09-26 Thread Srinivas Pandruvada
On Thu, 2019-09-26 at 08:54 -0400, Prarit Bhargava wrote: > The current code structure has similar but separate command functions > for > the enable and disable operations. This can be improved by adding an > int > argument to the command function structure, and interpreting 1 as > enable > and 0

[PATCH 1/7] intel-speed-select: Add int argument to command functions

2019-09-26 Thread Prarit Bhargava
The current code structure has similar but separate command functions for the enable and disable operations. This can be improved by adding an int argument to the command function structure, and interpreting 1 as enable and 0 as disable. This change results in the removal of the disable command