Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-08 Thread Enrico Weigelt, metux IT consult
On 05.12.20 16:53, Greg KH wrote: >> How do we feel about deleting this not really informative message >> altogether in a future patch? > > It too should be removed. If drivers are working properly, they are > quiet. Just sent a separate patch for removing this message. I'll rebase my patch

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Greg KH
On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Vladimir Oltean
On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- > net/8021q/vlan.c | 8 +--- > 1 file

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-05 Thread Joe Perches
On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult Thanks for the patches. Please drop the "metux IT consult"

[PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/8021q/vlan.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index