Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-06 Thread Darren Hart
On Tue, Mar 03, 2015 at 03:39:54PM -0300, Henrique de Moraes Holschuh wrote: > On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote: > > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt > > with it like the other drivers in platform/drivers/x86, when instead I > > should > >

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-06 Thread Darren Hart
On Tue, Mar 03, 2015 at 03:39:54PM -0300, Henrique de Moraes Holschuh wrote: On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote: Henrique, I believe I may have overstepped with thinkpad-acpi and dealt with it like the other drivers in platform/drivers/x86, when instead I should have been

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Henrique de Moraes Holschuh
On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote: > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt > with it like the other drivers in platform/drivers/x86, when instead I should > have been leaving it to you. My apologies, it was not intentional. No harm done! And I did

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Darren Hart
On Fri, Feb 27, 2015 at 08:16:19AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote: > > On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: > > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > > > Rather than

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Darren Hart
On Fri, Feb 27, 2015 at 08:16:19AM -0300, Henrique de Moraes Holschuh wrote: On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote: On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-03-03 Thread Henrique de Moraes Holschuh
On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote: Henrique, I believe I may have overstepped with thinkpad-acpi and dealt with it like the other drivers in platform/drivers/x86, when instead I should have been leaving it to you. My apologies, it was not intentional. No harm done! And I did

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote: > On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > > Rather than checking on each suspend and resume whether the laptop > > > has an adaptive keyboard, check

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Thu, Feb 26, 2015, at 08:22, Bastien Nocera wrote: > On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote: > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > > Rather than checking on each suspend and resume whether the laptop > > > has an adaptive keyboard, check when the

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > Rather than checking on each suspend and resume whether the laptop > > has an adaptive keyboard, check when the driver is initialised. > > Bastien, am I awaiting another

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Bastien, am I awaiting another version of

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Thu, Feb 26, 2015, at 08:22, Bastien Nocera wrote: On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote: On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is

Re: [ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-27 Thread Henrique de Moraes Holschuh
On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote: On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-26 Thread Bastien Nocera
On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote: > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > Rather than checking on each suspend and resume whether the laptop > > has an adaptive keyboard, check when the driver is initialised. > > Bastien, am I awaiting another

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-26 Thread Bastien Nocera
On Wed, 2015-02-25 at 22:18 -0800, Darren Hart wrote: On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Bastien, am I awaiting another version of

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-25 Thread Darren Hart
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > Rather than checking on each suspend and resume whether the laptop > has an adaptive keyboard, check when the driver is initialised. Bastien, am I awaiting another version of this from you to address comments from Henrique?

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-25 Thread Darren Hart
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Bastien, am I awaiting another version of this from you to address comments from Henrique?

[PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-20 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions(+), 19 deletions(-)

[PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-20 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions(+),