Re: [PATCH 1/8] Use __kernel_long_t in struct timex

2014-01-21 Thread Catalin Marinas
On Tue, Jan 21, 2014 at 05:03:09PM +, H. Peter Anvin wrote: > On 01/21/2014 08:58 AM, Catalin Marinas wrote: > > BTW, could we not avoid the #if and always use __kernel_long_t? This > > wouldn't break the user ABI. > > Ah yes, this is the wrong version of the patchset. I already gave that > f

Re: [PATCH 1/8] Use __kernel_long_t in struct timex

2014-01-21 Thread H. Peter Anvin
On 01/21/2014 08:58 AM, Catalin Marinas wrote: > > BTW, could we not avoid the #if and always use __kernel_long_t? This > wouldn't break the user ABI. > Ah yes, this is the wrong version of the patchset. I already gave that feedback and H.J. posted an update. My bad. -hpa -- To unsub

Re: [PATCH 1/8] Use __kernel_long_t in struct timex

2014-01-21 Thread Catalin Marinas
On Fri, Dec 27, 2013 at 05:25:05PM +, H.J. Lu wrote: > X32 adjtimex system call is the same as x86-64 adjtimex system call, > which uses 64-bit integer for long in struct timex. But x32 long is > 32 bit. This patch replaces long in struct timex with __kernel_long_t > if __BITS_PER_LONG == 64.

[PATCH 1/8] Use __kernel_long_t in struct timex

2013-12-27 Thread H.J. Lu
X32 adjtimex system call is the same as x86-64 adjtimex system call, which uses 64-bit integer for long in struct timex. But x32 long is 32 bit. This patch replaces long in struct timex with __kernel_long_t. Signed-off-by: H.J. Lu --- include/uapi/linux/timex.h | 34 +---

Re: [PATCH 1/8] Use __kernel_long_t in struct timex

2013-12-27 Thread H. Peter Anvin
On 12/27/2013 09:25 AM, H.J. Lu wrote: > X32 adjtimex system call is the same as x86-64 adjtimex system call, > which uses 64-bit integer for long in struct timex. But x32 long is > 32 bit. This patch replaces long in struct timex with __kernel_long_t > if __BITS_PER_LONG == 64. > > Signed-off-by

[PATCH 1/8] Use __kernel_long_t in struct timex

2013-12-27 Thread H.J. Lu
X32 adjtimex system call is the same as x86-64 adjtimex system call, which uses 64-bit integer for long in struct timex. But x32 long is 32 bit. This patch replaces long in struct timex with __kernel_long_t if __BITS_PER_LONG == 64. Signed-off-by: H.J. Lu --- include/uapi/linux/timex.h | 46 +++