Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-17 Thread Andi Kleen
> > I considered this. For this example it doesn't make much difference > > because the functions are so small. > > > > But for anything larger I really need the line numbers to make > > sense of it. > > > > So I prefer to keep them. I'll look into some easy switch > > to turn them off though. >

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-17 Thread Andi Kleen
I considered this. For this example it doesn't make much difference because the functions are so small. But for anything larger I really need the line numbers to make sense of it. So I prefer to keep them. I'll look into some easy switch to turn them off though. Oh, I'm not

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-16 Thread Namhyung Kim
Hi Andi, On Wed, 12 Nov 2014 00:31:53 +0100, Andi Kleen wrote: > Sorry for the long delay. Just revisiting that. > > On Wed, Oct 22, 2014 at 10:03:51AM +0900, Namhyung Kim wrote: >> > | | f2 tcall.c:5 >> > | | f1 tcall.c:12 >> >

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-16 Thread Namhyung Kim
Hi Andi, On Wed, 12 Nov 2014 00:31:53 +0100, Andi Kleen wrote: Sorry for the long delay. Just revisiting that. On Wed, Oct 22, 2014 at 10:03:51AM +0900, Namhyung Kim wrote: | | f2 tcall.c:5 | | f1 tcall.c:12 |

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-11 Thread Andi Kleen
Sorry for the long delay. Just revisiting that. On Wed, Oct 22, 2014 at 10:03:51AM +0900, Namhyung Kim wrote: > > | | f2 tcall.c:5 > > | | f1 tcall.c:12 > > | | f1 tcall.c:12 > > | |

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-11-11 Thread Andi Kleen
Sorry for the long delay. Just revisiting that. On Wed, Oct 22, 2014 at 10:03:51AM +0900, Namhyung Kim wrote: | | f2 tcall.c:5 | | f1 tcall.c:12 | | f1 tcall.c:12 | | f2

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-21 Thread Namhyung Kim
Hi Andi, On Fri, 26 Sep 2014 16:37:09 -0700, Andi Kleen wrote: > From: Andi Kleen > > Currently branch stacks can be only shown as edge histograms for > individual branches. I never found this display particularly useful. > > This implements an alternative mode that creates histograms over

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-21 Thread Namhyung Kim
Hi Andi, On Fri, 26 Sep 2014 16:37:09 -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-20 Thread Jiri Olsa
On Fri, Sep 26, 2014 at 04:37:09PM -0700, Andi Kleen wrote: > From: Andi Kleen SNIP > > struct callchain_list { > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index b2ec38b..8ba32ce 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -12,6

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-20 Thread Jiri Olsa
On Fri, Sep 26, 2014 at 04:37:09PM -0700, Andi Kleen wrote: SNIP > OPT_BOOLEAN('x', "exclude-other", _conf.exclude_other, > "Only display entries with parent-match"), > - OPT_CALLBACK_DEFAULT('g', "call-graph", , > "output_type,min_percent[,print_limit],call_order",

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-20 Thread Jiri Olsa
On Fri, Sep 26, 2014 at 04:37:09PM -0700, Andi Kleen wrote: SNIP OPT_BOOLEAN('x', exclude-other, symbol_conf.exclude_other, Only display entries with parent-match), - OPT_CALLBACK_DEFAULT('g', call-graph, report, output_type,min_percent[,print_limit],call_order,

Re: [PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-10-20 Thread Jiri Olsa
On Fri, Sep 26, 2014 at 04:37:09PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com SNIP struct callchain_list { diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index b2ec38b..8ba32ce 100644 --- a/tools/perf/util/machine.c +++

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-09-26 Thread Andi Kleen
From: Andi Kleen Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches, similar to how normal

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-09-26 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches,

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-09-15 Thread Andi Kleen
From: Andi Kleen Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches, similar to how normal

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms

2014-09-15 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches,

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms v5

2014-03-10 Thread Andi Kleen
From: Andi Kleen Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches, similar to how normal

[PATCH 1/8] perf, tools: Support handling complete branch stacks as histograms v5

2014-03-10 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Currently branch stacks can be only shown as edge histograms for individual branches. I never found this display particularly useful. This implements an alternative mode that creates histograms over complete branch traces, instead of individual branches,