Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-14 Thread Stanimir Varbanov
Hi Courtney, On 04/09/2014 01:00 AM, Courtney Cavin wrote: > On Tue, Apr 08, 2014 at 06:26:44PM +0200, Stanimir Varbanov wrote: >> On 04/04/2014 02:38 AM, Courtney Cavin wrote: >>> On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: This adds core driver files. The core part

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-14 Thread Stanimir Varbanov
Hi Courtney, On 04/09/2014 01:00 AM, Courtney Cavin wrote: On Tue, Apr 08, 2014 at 06:26:44PM +0200, Stanimir Varbanov wrote: On 04/04/2014 02:38 AM, Courtney Cavin wrote: On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: This adds core driver files. The core part is

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-08 Thread Courtney Cavin
On Tue, Apr 08, 2014 at 06:26:44PM +0200, Stanimir Varbanov wrote: > On 04/04/2014 02:38 AM, Courtney Cavin wrote: > > On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: > >> This adds core driver files. The core part is implementing a > >> platform driver probe and remove

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-08 Thread Stanimir Varbanov
Hi Courtney, Thanks for the review! On 04/04/2014 02:38 AM, Courtney Cavin wrote: > On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: >> This adds core driver files. The core part is implementing a >> platform driver probe and remove callbaks, the probe enables >> clocks, checks

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-08 Thread Stanimir Varbanov
Hi Courtney, Thanks for the review! On 04/04/2014 02:38 AM, Courtney Cavin wrote: On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the probe enables clocks, checks crypto

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-08 Thread Courtney Cavin
On Tue, Apr 08, 2014 at 06:26:44PM +0200, Stanimir Varbanov wrote: On 04/04/2014 02:38 AM, Courtney Cavin wrote: On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-04 Thread Stanimir Varbanov
Hi Josh, Thanks for the comments! On 04/03/2014 09:19 PM, Josh Cartwright wrote: > Hey Stanimir- > > Just a few comments/questions from a quick scan of your patchset: > > On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: > [..] >> +++ b/drivers/crypto/qce/core.c > [..] >> + >>

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-04 Thread Stanimir Varbanov
Hi Josh, Thanks for the comments! On 04/03/2014 09:19 PM, Josh Cartwright wrote: Hey Stanimir- Just a few comments/questions from a quick scan of your patchset: On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: [..] +++ b/drivers/crypto/qce/core.c [..] + +static

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Courtney Cavin
On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: > This adds core driver files. The core part is implementing a > platform driver probe and remove callbaks, the probe enables > clocks, checks crypto version, initialize and request dma > channels, create done tasklet and work

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Josh Cartwright
Hey Stanimir- Just a few comments/questions from a quick scan of your patchset: On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: [..] > +++ b/drivers/crypto/qce/core.c [..] > + > +static struct qce_algo_ops qce_ops[] = { > + { > + .type =

[PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Stanimir Varbanov
This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the probe enables clocks, checks crypto version, initialize and request dma channels, create done tasklet and work queue and finally register the algorithms into crypto subsystem.

[PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Stanimir Varbanov
This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the probe enables clocks, checks crypto version, initialize and request dma channels, create done tasklet and work queue and finally register the algorithms into crypto subsystem.

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Josh Cartwright
Hey Stanimir- Just a few comments/questions from a quick scan of your patchset: On Thu, Apr 03, 2014 at 07:17:58PM +0300, Stanimir Varbanov wrote: [..] +++ b/drivers/crypto/qce/core.c [..] + +static struct qce_algo_ops qce_ops[] = { + { + .type = CRYPTO_ALG_TYPE_ABLKCIPHER,

Re: [PATCH 1/9] crypto: qce: Add core driver implementation

2014-04-03 Thread Courtney Cavin
On Thu, Apr 03, 2014 at 06:17:58PM +0200, Stanimir Varbanov wrote: This adds core driver files. The core part is implementing a platform driver probe and remove callbaks, the probe enables clocks, checks crypto version, initialize and request dma channels, create done tasklet and work queue