Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-28 Thread Djalal Harouni
On Tue, May 27, 2014 at 11:38:54AM -0700, Kees Cook wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set the result accordingly. These flags are needed in case we have to cache the

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-28 Thread Kees Cook
On Wed, May 28, 2014 at 4:42 AM, Djalal Harouni tix...@opendz.org wrote: On Tue, May 27, 2014 at 11:38:54AM -0700, Kees Cook wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set the

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-28 Thread Djalal Harouni
On Wed, May 28, 2014 at 09:59:54AM -0700, Kees Cook wrote: On Wed, May 28, 2014 at 4:42 AM, Djalal Harouni tix...@opendz.org wrote: On Tue, May 27, 2014 at 11:38:54AM -0700, Kees Cook wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-27 Thread Djalal Harouni
On Mon, May 26, 2014 at 12:17:48PM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 12:13 PM, Djalal Harouni tix...@opendz.org wrote: On Mon, May 26, 2014 at 11:06:40AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 10:21 AM, Djalal Harouni tix...@opendz.org wrote: I would like

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-27 Thread Kees Cook
On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set the result accordingly. These flags are needed in case we have to cache the result of permission checks that are done during -open() time.

[PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Djalal Harouni
Add the deny or allow flags, so we can perform proper permission checks and set the result accordingly. These flags are needed in case we have to cache the result of permission checks that are done during -open() time. Later during -read(), we can decide to allow or deny the read(). The pid

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Andy Lutomirski
On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set the result accordingly. These flags are needed in case we have to cache the result of permission checks that are done during -open() time.

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Djalal Harouni
On Mon, May 26, 2014 at 09:57:16AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set the result accordingly. These flags are needed in case we have to cache

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Andy Lutomirski
On Mon, May 26, 2014 at 10:21 AM, Djalal Harouni tix...@opendz.org wrote: On Mon, May 26, 2014 at 09:57:16AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny or allow flags, so we can perform proper permission checks and set

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Djalal Harouni
On Mon, May 26, 2014 at 11:06:40AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 10:21 AM, Djalal Harouni tix...@opendz.org wrote: On Mon, May 26, 2014 at 09:57:16AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 6:27 AM, Djalal Harouni tix...@opendz.org wrote: Add the deny

Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/pid/$entry

2014-05-26 Thread Andy Lutomirski
On Mon, May 26, 2014 at 12:13 PM, Djalal Harouni tix...@opendz.org wrote: On Mon, May 26, 2014 at 11:06:40AM -0700, Andy Lutomirski wrote: On Mon, May 26, 2014 at 10:21 AM, Djalal Harouni tix...@opendz.org wrote: I would like to keep it enum, enum is type-safe and I want to follow the