Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-04-18 Thread Johannes Weiner
On Thu, Apr 11, 2013 at 08:57:58PM +0100, Mel Gorman wrote: > balance_pgdat() is very long and some of the logic can and should > be internal to kswapd_shrink_zone(). Move it so the flow of > balance_pgdat() is marginally easier to follow. > > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-04-11 Thread Rik van Riel
On 04/09/2013 07:07 AM, Mel Gorman wrote: balance_pgdat() is very long and some of the logic can and should be internal to kswapd_shrink_zone(). Move it so the flow of balance_pgdat() is marginally easier to follow. Signed-off-by: Mel Gorman Acked-by: Rik van Riel -- All rights reversed --

[PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-04-11 Thread Mel Gorman
balance_pgdat() is very long and some of the logic can and should be internal to kswapd_shrink_zone(). Move it so the flow of balance_pgdat() is marginally easier to follow. Signed-off-by: Mel Gorman --- mm/vmscan.c | 112 +--- 1 file chang

[PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-04-09 Thread Mel Gorman
balance_pgdat() is very long and some of the logic can and should be internal to kswapd_shrink_zone(). Move it so the flow of balance_pgdat() is marginally easier to follow. Signed-off-by: Mel Gorman --- mm/vmscan.c | 112 +--- 1 file chang

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-03-21 Thread Mel Gorman
On Thu, Mar 21, 2013 at 06:18:04PM +0100, Michal Hocko wrote: > On Sun 17-03-13 13:04:16, Mel Gorman wrote: > > + > > + /* > > +* Kswapd reclaims only single pages with compaction enabled. Trying > > +* too hard to reclaim until contiguous free pages have become > > +* available can h

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-03-21 Thread Michal Hocko
On Sun 17-03-13 13:04:16, Mel Gorman wrote: > balance_pgdat() is very long and some of the logic can and should > be internal to kswapd_shrink_zone(). Move it so the flow of > balance_pgdat() is marginally easier to follow. > > Signed-off-by: Mel Gorman > --- > mm/vmscan.c | 104 > +

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-03-17 Thread Mel Gorman
On Sun, Mar 17, 2013 at 07:55:54AM -0700, Andi Kleen wrote: > Mel Gorman writes: > > > + > > + /* > > +* We put equal pressure on every zone, unless one zone has way too > > +* many pages free already. The "too many pages" is defined as the > > +* high wmark plus a "gap" where the g

Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-03-17 Thread Andi Kleen
Mel Gorman writes: > + > + /* > + * We put equal pressure on every zone, unless one zone has way too > + * many pages free already. The "too many pages" is defined as the > + * high wmark plus a "gap" where the gap is either the low > + * watermark or 1% of the zone, which

[PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone()

2013-03-17 Thread Mel Gorman
balance_pgdat() is very long and some of the logic can and should be internal to kswapd_shrink_zone(). Move it so the flow of balance_pgdat() is marginally easier to follow. Signed-off-by: Mel Gorman --- mm/vmscan.c | 104 +--- 1 file chang