Re: [PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-28 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-27 Thread Christoph Hellwig
On Sun, Jul 26, 2020 at 12:06:39PM -0700, Minchan Kim wrote: > > @@ -528,8 +530,7 @@ static ssize_t backing_dev_store(struct device *dev, > > * freely but in fact, IO is going on so finally could cause > > * use-after-free when the IO is really done. > > */ > > - zram->disk->queue-

Re: [PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-26 Thread Minchan Kim
On Sun, Jul 26, 2020 at 05:03:29PM +0200, Christoph Hellwig wrote: > BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to > decided if ->rw_page can be used on a block device. Just check up for > the method instead. The only complication is that zram needs a second > set of block_

[PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-26 Thread Christoph Hellwig
BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to decided if ->rw_page can be used on a block device. Just check up for the method instead. The only complication is that zram needs a second set of block_device_operations as it can switch between modes that actually support ->rw

[PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-24 Thread Christoph Hellwig
BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to decided if ->rw_page can be used on a block device. Just check up for the method instead. The only complication is that zram needs a second set of block_device_operations as it can switch between modes that actually support ->rw

[PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-21 Thread Christoph Hellwig
BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to decided if ->rw_page can be used on a block device. Just check up for the method instead. The only complication is that zram needs a second set of block_device_operations as it can switch between modes that actually support ->rw

[PATCH 10/14] bdi: remove BDI_CAP_SYNCHRONOUS_IO

2020-07-20 Thread Christoph Hellwig
BDI_CAP_SYNCHRONOUS_IO is only checked in the swap code, and used to decided if ->rw_page can be used on a block device. Just check up for the method instead. Signed-off-by: Christoph Hellwig --- drivers/block/brd.c | 1 - drivers/block/zram/zram_drv.c | 17 + drivers