Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread Ian Kent
On Wed, 2020-08-05 at 13:27 +0200, Miklos Szeredi wrote: > On Wed, Aug 5, 2020 at 1:23 PM Ian Kent wrote: > > On Wed, 2020-08-05 at 09:45 +0200, Miklos Szeredi wrote: > > > Hmm, what's the other possibility for lost notifications? > > > > In user space that is: > > > > Multi-threaded

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread David Howells
Miklos Szeredi wrote: > Shoun't we just make sure that the likelyhood of overruns is low That's not necessarily easy. To avoid overruns you need a bigger buffer. The buffer is preallocated from unswappable kernel space. Yes, you can increase the size of the buffer, but it eats out of your

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread Ian Kent
On Wed, 2020-08-05 at 09:45 +0200, Miklos Szeredi wrote: > On Wed, Aug 5, 2020 at 4:46 AM Ian Kent wrote: > > Coming back to an actual use case. > > > > What I said above is one aspect but, since I'm looking at this > > right > > now with systemd, and I do have the legacy code to fall back to, >

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread Miklos Szeredi
On Wed, Aug 5, 2020 at 1:23 PM Ian Kent wrote: > > On Wed, 2020-08-05 at 09:45 +0200, Miklos Szeredi wrote: > > Hmm, what's the other possibility for lost notifications? > > In user space that is: > > Multi-threaded application races, single threaded applications and > signal processing races,

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread Miklos Szeredi
On Wed, Aug 5, 2020 at 6:07 PM David Howells wrote: > > Miklos Szeredi wrote: > > > Shoun't we just make sure that the likelyhood of overruns is low > > That's not necessarily easy. To avoid overruns you need a bigger buffer. The > buffer is preallocated from unswappable kernel space. Yes,

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-05 Thread Miklos Szeredi
On Wed, Aug 5, 2020 at 4:46 AM Ian Kent wrote: > > Coming back to an actual use case. > > What I said above is one aspect but, since I'm looking at this right > now with systemd, and I do have the legacy code to fall back to, the > "just reset everything" suggestion does make sense. > > But I'm

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-04 Thread Ian Kent
On Wed, 2020-08-05 at 10:05 +0800, Ian Kent wrote: > On Tue, 2020-08-04 at 15:56 +0200, Miklos Szeredi wrote: > > On Mon, Aug 03, 2020 at 02:37:50PM +0100, David Howells wrote: > > > Provide support for the handling of an overrun in a watch > > > queue. In the > > > event that an overrun occurs,

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-04 Thread Ian Kent
On Tue, 2020-08-04 at 15:56 +0200, Miklos Szeredi wrote: > On Mon, Aug 03, 2020 at 02:37:50PM +0100, David Howells wrote: > > Provide support for the handling of an overrun in a watch > > queue. In the > > event that an overrun occurs, the watcher needs to be able to find > > out what > > it was

Re: [PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-04 Thread Miklos Szeredi
On Mon, Aug 03, 2020 at 02:37:50PM +0100, David Howells wrote: > Provide support for the handling of an overrun in a watch queue. In the > event that an overrun occurs, the watcher needs to be able to find out what > it was that they missed. To this end, previous patches added event > counters

[PATCH 10/18] fsinfo: Provide notification overrun handling support [ver #21]

2020-08-03 Thread David Howells
Provide support for the handling of an overrun in a watch queue. In the event that an overrun occurs, the watcher needs to be able to find out what it was that they missed. To this end, previous patches added event counters to struct mount. To make them accessible, they can be retrieved using