Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread Nick Piggin
On Thursday 10 January 2008 02:45, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > It is to make everybody happy. Especially in code that everyone works > > on like mm/ and fs/, you can't just have everybody following their own > > slightly different conventions. > > Conventions

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > It is to make everybody happy. Especially in code that everyone works > on like mm/ and fs/, you can't just have everybody following their own > slightly different conventions. Conventions are what people agree they are. Anyway, I've attached a revised

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: It is to make everybody happy. Especially in code that everyone works on like mm/ and fs/, you can't just have everybody following their own slightly different conventions. Conventions are what people agree they are. Anyway, I've attached a revised page

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread Nick Piggin
On Thursday 10 January 2008 02:45, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: It is to make everybody happy. Especially in code that everyone works on like mm/ and fs/, you can't just have everybody following their own slightly different conventions. Conventions are what

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-08 Thread Nick Piggin
On Wednesday 09 January 2008 10:51, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > No. I mean call the bit PG_private2. That way non-pagecache and > > > > filesystems that don't use fscache can use it. > > > > > > The bit is

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-08 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > No. I mean call the bit PG_private2. That way non-pagecache and > > > filesystems that don't use fscache can use it. > > > > The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, > > much

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-08 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: Nick Piggin [EMAIL PROTECTED] wrote: No. I mean call the bit PG_private2. That way non-pagecache and filesystems that don't use fscache can use it. The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, much like PG_owner_priv_1

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-08 Thread Nick Piggin
On Wednesday 09 January 2008 10:51, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: Nick Piggin [EMAIL PROTECTED] wrote: No. I mean call the bit PG_private2. That way non-pagecache and filesystems that don't use fscache can use it. The bit is called PG_owner_priv_2, and

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread Nick Piggin
On Tuesday 08 January 2008 00:09, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > No. I mean call the bit PG_private2. That way non-pagecache and > > filesystems that don't use fscache can use it. > > The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, > much

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > No. I mean call the bit PG_private2. That way non-pagecache and > filesystems that don't use fscache can use it. The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, much like PG_owner_priv_1 is 'subclassed' to PG_checked as was

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread Nick Piggin
On Thursday 03 January 2008 03:27, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > Then make a PG_private2 bit and use that. > > To what end? Are you suggesting I should have: > > PG_private2 = PG_private | PG_fscache No. I mean call the bit PG_private2. That way

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread Nick Piggin
On Thursday 03 January 2008 03:27, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: Then make a PG_private2 bit and use that. To what end? Are you suggesting I should have: PG_private2 = PG_private | PG_fscache No. I mean call the bit PG_private2. That way non-pagecache and

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: No. I mean call the bit PG_private2. That way non-pagecache and filesystems that don't use fscache can use it. The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, much like PG_owner_priv_1 is 'subclassed' to PG_checked as was

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-07 Thread Nick Piggin
On Tuesday 08 January 2008 00:09, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: No. I mean call the bit PG_private2. That way non-pagecache and filesystems that don't use fscache can use it. The bit is called PG_owner_priv_2, and then 'subclassed' to PG_fscache, much like

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-02 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > Then make a PG_private2 bit and use that. To what end? Are you suggesting I should have: PG_private2 = PG_private | PG_fscache That's redundant information and doesn't help anything really. My suggestion (PG_private and PG_fscache separate and

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-02 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: Then make a PG_private2 bit and use that. To what end? Are you suggesting I should have: PG_private2 = PG_private | PG_fscache That's redundant information and doesn't help anything really. My suggestion (PG_private and PG_fscache separate and

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:33, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > I'd much prefer if you would handle this in the filesystem, and have > > > > it set PG_private whenever fscache needs to receive a callback, and > > > > DTRT depending on whether PG_fscache etc.

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-20 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > > > I'd much prefer if you would handle this in the filesystem, and have it > > > set PG_private whenever fscache needs to receive a callback, and DTRT > > > depending on whether PG_fscache etc. is set or not. > > > > That's tricky and slower[*]. One of

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-20 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: I'd much prefer if you would handle this in the filesystem, and have it set PG_private whenever fscache needs to receive a callback, and DTRT depending on whether PG_fscache etc. is set or not. That's tricky and slower[*]. One of the things I

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:33, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: I'd much prefer if you would handle this in the filesystem, and have it set PG_private whenever fscache needs to receive a callback, and DTRT depending on whether PG_fscache etc. is set or not.

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-17 Thread Nick Piggin
On Tuesday 18 December 2007 09:36, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > I'd much prefer if you would handle this in the filesystem, and have it > > set PG_private whenever fscache needs to receive a callback, and DTRT > > depending on whether PG_fscache etc. is set or

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-17 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > I'd much prefer if you would handle this in the filesystem, and have it > set PG_private whenever fscache needs to receive a callback, and DTRT > depending on whether PG_fscache etc. is set or not. That's tricky and slower[*]. One of the things I want to

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-17 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: I'd much prefer if you would handle this in the filesystem, and have it set PG_private whenever fscache needs to receive a callback, and DTRT depending on whether PG_fscache etc. is set or not. That's tricky and slower[*]. One of the things I want to do

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-17 Thread Nick Piggin
On Tuesday 18 December 2007 09:36, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: I'd much prefer if you would handle this in the filesystem, and have it set PG_private whenever fscache needs to receive a callback, and DTRT depending on whether PG_fscache etc. is set or not.

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:39, David Howells wrote: > Recruit a couple of page flags to aid in cache management. The following > extra flags are defined: > > (1) PG_fscache (PG_owner_priv_2) > > The marked page is backed by a local cache and is pinning resources in > the cache driver.

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:39, David Howells wrote: Recruit a couple of page flags to aid in cache management. The following extra flags are defined: (1) PG_fscache (PG_owner_priv_2) The marked page is backed by a local cache and is pinning resources in the cache driver. (2)

[PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-05 Thread David Howells
Recruit a couple of page flags to aid in cache management. The following extra flags are defined: (1) PG_fscache (PG_owner_priv_2) The marked page is backed by a local cache and is pinning resources in the cache driver. (2) PG_fscache_write (PG_owner_priv_3) The marked page

[PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2007-12-05 Thread David Howells
Recruit a couple of page flags to aid in cache management. The following extra flags are defined: (1) PG_fscache (PG_owner_priv_2) The marked page is backed by a local cache and is pinning resources in the cache driver. (2) PG_fscache_write (PG_owner_priv_3) The marked page