Re: [PATCH 11/11] mfd: max8925-i2c: Drop unnecessary static

2017-07-18 Thread Lee Jones
On Sat, 15 Jul 2017, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @bad exists@ >

Re: [PATCH 11/11] mfd: max8925-i2c: Drop unnecessary static

2017-07-18 Thread Lee Jones
On Sat, 15 Jul 2017, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @bad exists@ >

[PATCH 11/11] mfd: max8925-i2c: Drop unnecessary static

2017-07-15 Thread Julia Lawall
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x =

[PATCH 11/11] mfd: max8925-i2c: Drop unnecessary static

2017-07-15 Thread Julia Lawall
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x =