Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-21 Thread Mel Gorman
On Fri, Sep 18, 2015 at 03:38:35PM +0900, Joonsoo Kim wrote: > > > And, there is some mismatch that check atomic high-order allocation. > > > In some place, you checked __GFP_ATOMIC, but some other places, > > > you checked ALLOC_HARDER. It is better to use unified one. > > > Introducing helper

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-21 Thread Mel Gorman
On Fri, Sep 18, 2015 at 03:38:35PM +0900, Joonsoo Kim wrote: > > > And, there is some mismatch that check atomic high-order allocation. > > > In some place, you checked __GFP_ATOMIC, but some other places, > > > you checked ALLOC_HARDER. It is better to use unified one. > > > Introducing helper

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-18 Thread Joonsoo Kim
On Wed, Sep 09, 2015 at 01:32:39PM +0100, Mel Gorman wrote: > On Tue, Sep 08, 2015 at 05:01:06PM +0900, Joonsoo Kim wrote: > > 2015-08-24 21:29 GMT+09:00 Mel Gorman : > > > > > > > > > +/* > > > + * Reserve a pageblock for exclusive use of high-order atomic > > > allocations if > > > + * there

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-18 Thread Joonsoo Kim
On Wed, Sep 09, 2015 at 01:32:39PM +0100, Mel Gorman wrote: > On Tue, Sep 08, 2015 at 05:01:06PM +0900, Joonsoo Kim wrote: > > 2015-08-24 21:29 GMT+09:00 Mel Gorman : > > > > > > > > > +/* > > > + * Reserve a pageblock for exclusive use of high-order atomic > > >

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-09 Thread Mel Gorman
On Tue, Sep 08, 2015 at 05:01:06PM +0900, Joonsoo Kim wrote: > 2015-08-24 21:29 GMT+09:00 Mel Gorman : > > > > > > +/* > > + * Reserve a pageblock for exclusive use of high-order atomic allocations > > if > > + * there are no empty page blocks that contain a page with a suitable order > > + */ >

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-09 Thread Mel Gorman
On Tue, Sep 08, 2015 at 05:01:06PM +0900, Joonsoo Kim wrote: > 2015-08-24 21:29 GMT+09:00 Mel Gorman : > > > > > > +/* > > + * Reserve a pageblock for exclusive use of high-order atomic allocations > > if > > + * there are no empty page blocks that contain a page

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-08 Thread Joonsoo Kim
2015-08-24 21:29 GMT+09:00 Mel Gorman : > High-order watermark checking exists for two reasons -- kswapd high-order > awareness and protection for high-order atomic requests. Historically the > kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order > free pages for as long

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-09-08 Thread Joonsoo Kim
2015-08-24 21:29 GMT+09:00 Mel Gorman : > High-order watermark checking exists for two reasons -- kswapd high-order > awareness and protection for high-order atomic requests. Historically the > kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Mel Gorman
On Wed, Aug 26, 2015 at 04:53:52PM +0200, Michal Hocko wrote: > > > > Overall, this is a small reduction but the reserves are small relative to > > the > > number of allocation requests. In early versions of the patch, the failure > > rate reduced by a much larger amount but that required much

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Michal Hocko
On Mon 24-08-15 13:29:57, Mel Gorman wrote: > High-order watermark checking exists for two reasons -- kswapd high-order > awareness and protection for high-order atomic requests. Historically the > kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order > free pages for as

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Vlastimil Babka
On 08/24/2015 02:29 PM, Mel Gorman wrote: High-order watermark checking exists for two reasons -- kswapd high-order awareness and protection for high-order atomic requests. Historically the kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order free pages for as long as

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Vlastimil Babka
On 08/24/2015 02:29 PM, Mel Gorman wrote: High-order watermark checking exists for two reasons -- kswapd high-order awareness and protection for high-order atomic requests. Historically the kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order free pages for as long as

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Michal Hocko
On Mon 24-08-15 13:29:57, Mel Gorman wrote: High-order watermark checking exists for two reasons -- kswapd high-order awareness and protection for high-order atomic requests. Historically the kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order free pages for as long

Re: [PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-26 Thread Mel Gorman
On Wed, Aug 26, 2015 at 04:53:52PM +0200, Michal Hocko wrote: Overall, this is a small reduction but the reserves are small relative to the number of allocation requests. In early versions of the patch, the failure rate reduced by a much larger amount but that required much larger

[PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-24 Thread Mel Gorman
High-order watermark checking exists for two reasons -- kswapd high-order awareness and protection for high-order atomic requests. Historically the kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order free pages for as long as possible. This patch introduces

[PATCH 11/12] mm, page_alloc: Reserve pageblocks for high-order atomic allocations on demand

2015-08-24 Thread Mel Gorman
High-order watermark checking exists for two reasons -- kswapd high-order awareness and protection for high-order atomic requests. Historically the kernel depended on MIGRATE_RESERVE to preserve min_free_kbytes as high-order free pages for as long as possible. This patch introduces