Re: [PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu()

2020-06-02 Thread Qian Cai
On Tue, Jun 02, 2020 at 05:05:11PM +0200, Peter Zijlstra wrote: > On Tue, Jun 02, 2020 at 10:42:35AM -0400, Qian Cai wrote: > > > Reverted this commit fixed the POWER9 boot warning, > > ARGH, I'm an idiot. Please try this instead: > > > diff --git a/kernel/softirq.c b/kernel/softirq.c > index

Re: [PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu()

2020-06-02 Thread Peter Zijlstra
On Tue, Jun 02, 2020 at 10:42:35AM -0400, Qian Cai wrote: > Reverted this commit fixed the POWER9 boot warning, ARGH, I'm an idiot. Please try this instead: diff --git a/kernel/softirq.c b/kernel/softirq.c index a3eb6eba8c41..c4201b7f42b1 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@

Re: [PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu()

2020-06-02 Thread Qian Cai
On Fri, May 29, 2020 at 11:27:39PM +0200, Peter Zijlstra wrote: > Because: > > irq_enter_rcu() includes lockdep_hardirq_enter() > irq_exit_rcu() does *NOT* include lockdep_hardirq_exit() > > Which resulted in two 'stray' lockdep_hardirq_exit() calls in > idtentry.h, and me spending a long

[PATCH 11/14] x86/entry: Clarify irq_{enter,exit}_rcu()

2020-05-29 Thread Peter Zijlstra
Because: irq_enter_rcu() includes lockdep_hardirq_enter() irq_exit_rcu() does *NOT* include lockdep_hardirq_exit() Which resulted in two 'stray' lockdep_hardirq_exit() calls in idtentry.h, and me spending a long time trying to find the matching enter calls. Signed-off-by: Peter Zijlstra