Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-03-02 Thread Oded Gabbay
On Sat, Mar 2, 2019 at 3:00 AM Joe Perches wrote: > > On Thu, 2019-02-28 at 11:55 +0200, Oded Gabbay wrote: > > Don't cast pointer to u64 to print it. Instead, print the pointer using > > %p. > > You might want to use %px here if you _really_ > want the actual address and not the hashed output >

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-03-01 Thread Joe Perches
On Thu, 2019-02-28 at 11:55 +0200, Oded Gabbay wrote: > Don't cast pointer to u64 to print it. Instead, print the pointer using > %p. You might want to use %px here if you _really_ want the actual address and not the hashed output %p normally produces. > diff --git

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Oded Gabbay
On Thu, Feb 28, 2019 at 2:02 PM Greg KH wrote: > > On Thu, Feb 28, 2019 at 11:55:45AM +0200, Oded Gabbay wrote: > > Don't cast pointer to u64 to print it. Instead, print the pointer using > > %p. > > > > Signed-off-by: Oded Gabbay > > --- > > Changes in v2: > > - Add changelog in the commit

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 11:55:45AM +0200, Oded Gabbay wrote: > Don't cast pointer to u64 to print it. Instead, print the pointer using > %p. > > Signed-off-by: Oded Gabbay > --- > Changes in v2: > - Add changelog in the commit message This isn't marked "v2" :( Anyway, I'll try to piece this

[PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Oded Gabbay
Don't cast pointer to u64 to print it. Instead, print the pointer using %p. Signed-off-by: Oded Gabbay --- Changes in v2: - Add changelog in the commit message drivers/misc/habanalabs/goya/goya.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Oded Gabbay
On Thu, Feb 28, 2019 at 11:31 AM Greg KH wrote: > > On Thu, Feb 28, 2019 at 10:46:20AM +0200, Oded Gabbay wrote: > > Signed-off-by: Oded Gabbay > > I can't take patches without any changelog text :( > ah, didn't know it was required for even this trivial change. I'll resend this and another

Re: [PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 10:46:20AM +0200, Oded Gabbay wrote: > Signed-off-by: Oded Gabbay I can't take patches without any changelog text :(

[PATCH 11/15] habanalabs: print pointer using %p

2019-02-28 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/goya/goya.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index 13923f4127af..39824214ce61 100644 --- a/drivers/misc/habanalabs/goya/goya.c