Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Namhyung Kim
Hi Andi, On Sat, Mar 1, 2014 at 1:07 AM, Andi Kleen wrote: >> I don't think I understand the problem enough to know what to fix. I just >> copied this piece of code from builtin-report.c and things seemed to work. >> >> Mind giving me some details and I can look at fixing it. :-) > > sort.c

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Andi Kleen
> I don't think I understand the problem enough to know what to fix. I just > copied this piece of code from builtin-report.c and things seemed to work. > > Mind giving me some details and I can look at fixing it. :-) sort.c even though has all these sort keys only sorts by period. It should

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Don Zickus
On Fri, Feb 28, 2014 at 10:59:18AM -0800, Andi Kleen wrote: > Don Zickus writes: > > + > > + /* > > +* must pass period=weight in order to get the correct > > +* sorting from hists__collapse_resort() which is solely > > +* based on periods. We want sorting be done on nr_events *

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Andi Kleen
Don Zickus writes: > + > + /* > + * must pass period=weight in order to get the correct > + * sorting from hists__collapse_resort() which is solely > + * based on periods. We want sorting be done on nr_events * weight > + * and this is indirectly achieved by passing

[PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Don Zickus
Now that the infrastructure is set, add in the support to use hist_entry to sort on physid. Signed-off-by: Don Zickus --- tools/perf/builtin-c2c.c | 63 ++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-c2c.c

[PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Don Zickus
Now that the infrastructure is set, add in the support to use hist_entry to sort on physid. Signed-off-by: Don Zickus dzic...@redhat.com --- tools/perf/builtin-c2c.c | 63 ++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Andi Kleen
Don Zickus dzic...@redhat.com writes: + + /* + * must pass period=weight in order to get the correct + * sorting from hists__collapse_resort() which is solely + * based on periods. We want sorting be done on nr_events * weight + * and this is indirectly achieved by

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Don Zickus
On Fri, Feb 28, 2014 at 10:59:18AM -0800, Andi Kleen wrote: Don Zickus dzic...@redhat.com writes: + + /* +* must pass period=weight in order to get the correct +* sorting from hists__collapse_resort() which is solely +* based on periods. We want sorting be done on

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Andi Kleen
I don't think I understand the problem enough to know what to fix. I just copied this piece of code from builtin-report.c and things seemed to work. Mind giving me some details and I can look at fixing it. :-) sort.c even though has all these sort keys only sorts by period. It should

Re: [PATCH 11/19] perf, c2c: Add in sort on physid

2014-02-28 Thread Namhyung Kim
Hi Andi, On Sat, Mar 1, 2014 at 1:07 AM, Andi Kleen a...@firstfloor.org wrote: I don't think I understand the problem enough to know what to fix. I just copied this piece of code from builtin-report.c and things seemed to work. Mind giving me some details and I can look at fixing it. :-)