Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-27 Thread Miklos Szeredi
On Fri, Mar 27, 2015 at 3:42 PM, David Howells wrote: > Miklos Szeredi wrote: > >> I think this is confusing as hell, there needs to be more consistency >> in the naming. E.g. d_backing_is_positive() vs. d_is_positive(). I >> know it's the other way round now, but only with a few users. > >

Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-27 Thread David Howells
Miklos Szeredi wrote: > I think this is confusing as hell, there needs to be more consistency > in the naming. E.g. d_backing_is_positive() vs. d_is_positive(). I > know it's the other way round now, but only with a few users. Yeah. The problem is that all of: __d_entry_type()

Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-27 Thread David Howells
Miklos Szeredi mik...@szeredi.hu wrote: I think this is confusing as hell, there needs to be more consistency in the naming. E.g. d_backing_is_positive() vs. d_is_positive(). I know it's the other way round now, but only with a few users. Yeah. The problem is that all of:

Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-27 Thread Miklos Szeredi
On Fri, Mar 27, 2015 at 3:42 PM, David Howells dhowe...@redhat.com wrote: Miklos Szeredi mik...@szeredi.hu wrote: I think this is confusing as hell, there needs to be more consistency in the naming. E.g. d_backing_is_positive() vs. d_is_positive(). I know it's the other way round now, but

Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-26 Thread Miklos Szeredi
On Wed, Mar 25, 2015 at 3:45 PM, David Howells wrote: > Supply two functions to test whether a filesystem's own dentries are positive > or negative (d_really_is_positive() and d_really_is_negative()). > > The problem is that the DCACHE_ENTRY_TYPE field of dentry->d_flags may be > overridden by

Re: [PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-26 Thread Miklos Szeredi
On Wed, Mar 25, 2015 at 3:45 PM, David Howells dhowe...@redhat.com wrote: Supply two functions to test whether a filesystem's own dentries are positive or negative (d_really_is_positive() and d_really_is_negative()). The problem is that the DCACHE_ENTRY_TYPE field of dentry-d_flags may be

[PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-25 Thread David Howells
Supply two functions to test whether a filesystem's own dentries are positive or negative (d_really_is_positive() and d_really_is_negative()). The problem is that the DCACHE_ENTRY_TYPE field of dentry->d_flags may be overridden by the union part of a layered filesystem and isn't thus necessarily

[PATCH 12/15] VFS: Add owner-filesystem positive/negative dentry checks

2015-03-25 Thread David Howells
Supply two functions to test whether a filesystem's own dentries are positive or negative (d_really_is_positive() and d_really_is_negative()). The problem is that the DCACHE_ENTRY_TYPE field of dentry-d_flags may be overridden by the union part of a layered filesystem and isn't thus necessarily