Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Tue, 13 Feb 2018 00:47:50 +0900 Masami Hiramatsu wrote: > > > if (WARN_ON(!fevent->last_arg)) > > > break; > > > - ret = kstrtoul(token, 0, ); > > > - if (ret < 0) > > > - break; > > > + if

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Tue, 13 Feb 2018 00:47:50 +0900 Masami Hiramatsu wrote: > > > if (WARN_ON(!fevent->last_arg)) > > > break; > > > - ret = kstrtoul(token, 0, ); > > > - if (ret < 0) > > > - break; > > > + if (isalpha(token[0]) || token[0] !=

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Mon, 12 Feb 2018 11:06:44 +0900 Namhyung Kim wrote: > Hi Steve, > > On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > > On Fri, 9 Feb 2018 09:34:36 +0900 > > Namhyung Kim wrote: > > > > > Couldn't we use the symbol name directly?

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Mon, 12 Feb 2018 11:06:44 +0900 Namhyung Kim wrote: > Hi Steve, > > On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > > On Fri, 9 Feb 2018 09:34:36 +0900 > > Namhyung Kim wrote: > > > > > Couldn't we use the symbol name directly? Maybe it needs a syntax to > > > indicate

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

Hi Steve, On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 09:34:36 +0900 > Namhyung Kim wrote: > > > Couldn't we use the symbol name directly? Maybe it needs a syntax to > > indicate global variable. Like this? > > > > # echo

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

Hi Steve, On Fri, Feb 09, 2018 at 05:07:37PM -0500, Steven Rostedt wrote: > On Fri, 9 Feb 2018 09:34:36 +0900 > Namhyung Kim wrote: > > > Couldn't we use the symbol name directly? Maybe it needs a syntax to > > indicate global variable. Like this? > > > > # echo 'do_IRQ(int $total_forks)'

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, 9 Feb 2018 09:34:36 +0900 Namhyung Kim wrote: > Couldn't we use the symbol name directly? Maybe it needs a syntax to > indicate global variable. Like this? > > # echo 'do_IRQ(int $total_forks)' > function_events I decided to stick with "$". -- Steve >From

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, 9 Feb 2018 09:34:36 +0900 Namhyung Kim wrote: > Couldn't we use the symbol name directly? Maybe it needs a syntax to > indicate global variable. Like this? > > # echo 'do_IRQ(int $total_forks)' > function_events I decided to stick with "$". -- Steve >From

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, 9 Feb 2018 09:34:36 +0900 Namhyung Kim wrote: > > +Direct memory access > > + > > + > > +Function arguments are not the only thing that can be recorded from a > > function > > +based event. Memory addresses can also be examined. If there's a

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, 9 Feb 2018 09:34:36 +0900 Namhyung Kim wrote: > > +Direct memory access > > + > > + > > +Function arguments are not the only thing that can be recorded from a > > function > > +based event. Memory addresses can also be examined. If there's a global > > variable > >

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, Feb 02, 2018 at 06:05:10PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow referencing any address during the function based event. The syntax is > to use = For example: > > # echo 'do_IRQ(long total_forks=0xa2a4b4c0)' >

Re: [PATCH 12/18] tracing: Add accessing direct address from function based events

On Fri, Feb 02, 2018 at 06:05:10PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Allow referencing any address during the function based event. The syntax is > to use = For example: > > # echo 'do_IRQ(long total_forks=0xa2a4b4c0)' > function_events > # echo 1 >

[PATCH 12/18] tracing: Add accessing direct address from function based events

From: "Steven Rostedt (VMware)" Allow referencing any address during the function based event. The syntax is to use = For example: # echo 'do_IRQ(long total_forks=0xa2a4b4c0)' > function_events # echo 1 > events/function/enable # cat trace sshd-832

[PATCH 12/18] tracing: Add accessing direct address from function based events

From: "Steven Rostedt (VMware)" Allow referencing any address during the function based event. The syntax is to use = For example: # echo 'do_IRQ(long total_forks=0xa2a4b4c0)' > function_events # echo 1 > events/function/enable # cat trace sshd-832 [000] d...