Re: [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: > By passing idefloppy_floppy_t *floppy to the factored out functions, we get > rid of (almost) all local vars so stack usage should be at minimum here. Also, > we merge idefloppy_begin_format() into idefloppy_format_start() since it is > its >

Re: [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-12 Thread Bartlomiej Zolnierkiewicz
On Friday 11 January 2008, Borislav Petkov wrote: By passing idefloppy_floppy_t *floppy to the factored out functions, we get rid of (almost) all local vars so stack usage should be at minimum here. Also, we merge idefloppy_begin_format() into idefloppy_format_start() since it is its only

[PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-11 Thread Borislav Petkov
By passing idefloppy_floppy_t *floppy to the factored out functions, we get rid of (almost) all local vars so stack usage should be at minimum here. Also, we merge idefloppy_begin_format() into idefloppy_format_start() since it is its only user. Also, - remove unneeded scsi ioctl chunk - rename

[PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl()

2008-01-11 Thread Borislav Petkov
By passing idefloppy_floppy_t *floppy to the factored out functions, we get rid of (almost) all local vars so stack usage should be at minimum here. Also, we merge idefloppy_begin_format() into idefloppy_format_start() since it is its only user. Also, - remove unneeded scsi ioctl chunk - rename