Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Dave Hansen
On Tue, 2007-02-13 at 09:58 -0800, Andrew Morton wrote: > > On Tue, 13 Feb 2007 08:58:16 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > > > yipes. A new mount-wide spin_lock/unlock for each for-writing open() and > > > close(). > > > Can we have a microbenchmark on this please? > > > > Yeah,

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Andrew Morton
> On Tue, 13 Feb 2007 08:58:16 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > > yipes. A new mount-wide spin_lock/unlock for each for-writing open() and > > close(). > > Can we have a microbenchmark on this please? > > Yeah, I'll schedule some dbench time on a NUMA machine. dbench doesn't do

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Dave Hansen
On Mon, 2007-02-12 at 21:11 -0800, Andrew Morton wrote: > On Fri, 09 Feb 2007 14:53:37 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > > > diff -puN > > fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed > > fs/file_table.c > > ---

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Dave Hansen
On Mon, 2007-02-12 at 21:11 -0800, Andrew Morton wrote: On Fri, 09 Feb 2007 14:53:37 -0800 Dave Hansen [EMAIL PROTECTED] wrote: diff -puN fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed fs/file_table.c ---

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Andrew Morton
On Tue, 13 Feb 2007 08:58:16 -0800 Dave Hansen [EMAIL PROTECTED] wrote: yipes. A new mount-wide spin_lock/unlock for each for-writing open() and close(). Can we have a microbenchmark on this please? Yeah, I'll schedule some dbench time on a NUMA machine. dbench doesn't do open() a

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-13 Thread Dave Hansen
On Tue, 2007-02-13 at 09:58 -0800, Andrew Morton wrote: On Tue, 13 Feb 2007 08:58:16 -0800 Dave Hansen [EMAIL PROTECTED] wrote: yipes. A new mount-wide spin_lock/unlock for each for-writing open() and close(). Can we have a microbenchmark on this please? Yeah, I'll schedule some

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-12 Thread Andrew Morton
On Fri, 09 Feb 2007 14:53:37 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > diff -puN fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed > fs/file_table.c > --- lxc/fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed > 2007-02-09 14:26:54.0 -0800 > +++

Re: [PATCH 12/22] elevate write count files are open()ed

2007-02-12 Thread Andrew Morton
On Fri, 09 Feb 2007 14:53:37 -0800 Dave Hansen [EMAIL PROTECTED] wrote: diff -puN fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed fs/file_table.c --- lxc/fs/file_table.c~14-24-tricky-elevate-write-count-files-are-open-ed 2007-02-09 14:26:54.0 -0800 +++

[PATCH 12/22] elevate write count files are open()ed

2007-02-09 Thread Dave Hansen
This is the first really tricky patch in the series. It elevates the writer count on a mount each time a non-special file is opened for write. This is not completely apparent in the patch because the two if() conditions in may_open() above the mnt_want_write() call are, combined, equivalent to

[PATCH 12/22] elevate write count files are open()ed

2007-02-09 Thread Dave Hansen
This is the first really tricky patch in the series. It elevates the writer count on a mount each time a non-special file is opened for write. This is not completely apparent in the patch because the two if() conditions in may_open() above the mnt_want_write() call are, combined, equivalent to