Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-30 Thread Boris Brezillon
On Tue, 31 May 2016 00:28:24 +0200 Boris Brezillon wrote: > On Mon, 30 May 2016 16:56:09 -0400 > valdis.kletni...@vt.edu wrote: > > > On Mon, 30 May 2016 09:44:46 +0200, Boris Brezillon said: > > > Hi Valdis, > > > > > Actually, that was my first reaction [1], but the more I think about

Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-30 Thread Boris Brezillon
On Mon, 30 May 2016 16:56:09 -0400 valdis.kletni...@vt.edu wrote: > On Mon, 30 May 2016 09:44:46 +0200, Boris Brezillon said: > > Hi Valdis, > > > Actually, that was my first reaction [1], but the more I think about it > > the more I realize it's a non-issue. > > AFAICT, there's no full-id entr

Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-30 Thread Valdis . Kletnieks
On Mon, 30 May 2016 09:44:46 +0200, Boris Brezillon said: > Hi Valdis, > Actually, that was my first reaction [1], but the more I think about it > the more I realize it's a non-issue. > AFAICT, there's no full-id entries for Samsung NANDs in the nand_ids > table, so this either means there's no re

Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-30 Thread Boris Brezillon
Hi Valdis, On Sun, 29 May 2016 20:20:35 -0400 valdis.kletni...@vt.edu wrote: > On Fri, 27 May 2016 14:54:59 +0200, Boris Brezillon said: > > From: Hans de Goede > > > > On some nand controllers with hw-ecc the controller code wants to know > > the ecc strength and size and having these as 0, 0 i

Re: [PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-29 Thread Valdis . Kletnieks
On Fri, 27 May 2016 14:54:59 +0200, Boris Brezillon said: > From: Hans de Goede > > On some nand controllers with hw-ecc the controller code wants to know > the ecc strength and size and having these as 0, 0 is not accepted. > > Specifying these in devicetree is possible but undesirable as the nan

[PATCH 13/15] mtd: nand: samsung: retrieve ECC requirements from extended ID

2016-05-27 Thread Boris Brezillon
From: Hans de Goede On some nand controllers with hw-ecc the controller code wants to know the ecc strength and size and having these as 0, 0 is not accepted. Specifying these in devicetree is possible but undesirable as the nand may be different in different production runs of the same board, s