Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-26 Thread Kent Gibson
On Wed, Jun 24, 2020 at 11:40:57PM +0800, Kent Gibson wrote: > On Wed, Jun 24, 2020 at 05:33:26PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 23, 2020 at 7:04 AM Kent Gibson wrote: > > > > > > Add a new version of the uAPI to address existing 32/64bit alignment > > [ snip ] > > > > I'm

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 04:36:22PM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > [ snip ] > > + > > +/* > > + * Struct padding sizes. > > + * > > + * These are sized to pad structs to 64bit boundaries. > > + * To maintain 32/64bit alignment, any

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 05:33:26PM +0300, Andy Shevchenko wrote: > On Tue, Jun 23, 2020 at 7:04 AM Kent Gibson wrote: > > > > Add a new version of the uAPI to address existing 32/64bit alignment > > I think using - would be nice, like 32/64-bit (or at least space like > 32/64 bit) as a common

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > Add a new version of the uAPI to address existing 32/64bit alignment > issues, add support for debounce and event sequence numbers, and provide > some future proofing by adding padding reserved for future use. > > The alignment issue relates to

Re: [PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-24 Thread Andy Shevchenko
On Tue, Jun 23, 2020 at 7:04 AM Kent Gibson wrote: > > Add a new version of the uAPI to address existing 32/64bit alignment I think using - would be nice, like 32/64-bit (or at least space like 32/64 bit) as a common practice. > issues, add support for debounce and event sequence numbers, and

[PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-22 Thread Kent Gibson
Add a new version of the uAPI to address existing 32/64bit alignment issues, add support for debounce and event sequence numbers, and provide some future proofing by adding padding reserved for future use. The alignment issue relates to the gpioevent_data, which packs to different sizes on 32bit