Re: [PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-06 Thread Ardelean, Alexandru
On Tue, 2019-08-06 at 07:52 +0200, Heiner Kallweit wrote: > [External] > > On 05.08.2019 18:54, Alexandru Ardelean wrote: > > Down-speed auto-negotiation may not always be enabled, in which case the > > PHY won't down-shift to 100 or 10 during auto-negotiation. > > > > Signed-off-by: Alexandru

Re: [PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-06 Thread Ardelean, Alexandru
On Mon, 2019-08-05 at 17:22 +0200, Andrew Lunn wrote: > [External] > > On Mon, Aug 05, 2019 at 07:54:51PM +0300, Alexandru Ardelean wrote: > > Down-speed auto-negotiation may not always be enabled, in which case the > > PHY won't down-shift to 100 or 10 during auto-negotiation. > > Please look

Re: [PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-05 Thread Heiner Kallweit
On 05.08.2019 18:54, Alexandru Ardelean wrote: > Down-speed auto-negotiation may not always be enabled, in which case the > PHY won't down-shift to 100 or 10 during auto-negotiation. > > Signed-off-by: Alexandru Ardelean > --- > drivers/net/phy/adin.c | 27 +++ > 1 file

Re: [PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-05 Thread Andrew Lunn
On Mon, Aug 05, 2019 at 07:54:51PM +0300, Alexandru Ardelean wrote: > Down-speed auto-negotiation may not always be enabled, in which case the > PHY won't down-shift to 100 or 10 during auto-negotiation. Please look at how the marvell driver enables and configures this feature. Ideally we want

[PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-05 Thread Alexandru Ardelean
Down-speed auto-negotiation may not always be enabled, in which case the PHY won't down-shift to 100 or 10 during auto-negotiation. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 27 +++ 1 file changed, 27 insertions(+) diff --git