Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Wed, Feb 10, 2016 at 01:29:31PM +0100, Jiri Olsa wrote: > On Wed, Feb 10, 2016 at 01:23:45PM +0100, Jiri Olsa wrote: > > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > > > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > > > + for (nd =

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Wed, Feb 10, 2016 at 01:13:35PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > SNIP > > > + printed += fprintf(fp, "%s\n", buf); > > + > > + if (symbol_conf.use_callchain && he->leaf) { > > + u64 total = hists__total_period(hists); >

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Tue, Feb 09, 2016 at 11:01:17PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > The hierarchy output mode is to group entries for each level so that > > user can see higher level picture more easily. It also helps to find > > out which component is

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Wed, Feb 10, 2016 at 01:23:45PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > SNIP > > > > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > > + for (nd = rb_first(>entries); nd; nd = rb_hierarchy_next(nd)) { > > struct

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: SNIP > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > + for (nd = rb_first(>entries); nd; nd = rb_hierarchy_next(nd)) { > struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); >

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: SNIP > + printed += fprintf(fp, "%s\n", buf); > + > + if (symbol_conf.use_callchain && he->leaf) { > + u64 total = hists__total_period(hists); > + > + printed += hist_entry_callchain__fprintf(he, total,

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Wed, Feb 10, 2016 at 01:29:31PM +0100, Jiri Olsa wrote: > On Wed, Feb 10, 2016 at 01:23:45PM +0100, Jiri Olsa wrote: > > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > > > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > > > + for (nd =

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Tue, Feb 09, 2016 at 11:01:17PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > The hierarchy output mode is to group entries for each level so that > > user can see higher level picture more easily. It also helps to find > > out which component is

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Namhyung Kim
On Wed, Feb 10, 2016 at 01:13:35PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > SNIP > > > + printed += fprintf(fp, "%s\n", buf); > > + > > + if (symbol_conf.use_callchain && he->leaf) { > > + u64 total = hists__total_period(hists); >

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Wed, Feb 10, 2016 at 01:23:45PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > > SNIP > > > > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > > + for (nd = rb_first(>entries); nd; nd = rb_hierarchy_next(nd)) { > > struct

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: SNIP > + printed += fprintf(fp, "%s\n", buf); > + > + if (symbol_conf.use_callchain && he->leaf) { > + u64 total = hists__total_period(hists); > + > + printed += hist_entry_callchain__fprintf(he, total,

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-10 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: SNIP > > - for (nd = rb_first(>entries); nd; nd = rb_next(nd)) { > + for (nd = rb_first(>entries); nd; nd = rb_hierarchy_next(nd)) { > struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); >

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-09 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > The hierarchy output mode is to group entries for each level so that > user can see higher level picture more easily. It also helps to find > out which component is most costly. The output will look like below: > > 15.11%

Re: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-09 Thread Jiri Olsa
On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote: > The hierarchy output mode is to group entries for each level so that > user can see higher level picture more easily. It also helps to find > out which component is most costly. The output will look like below: > > 15.11%

[PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-05 Thread Namhyung Kim
The hierarchy output mode is to group entries for each level so that user can see higher level picture more easily. It also helps to find out which component is most costly. The output will look like below: 15.11% swapper 14.97% [kernel.vmlinux] 0.09%

[PATCH 14/23] perf ui/stdio: Implement hierarchy output mode

2016-02-05 Thread Namhyung Kim
The hierarchy output mode is to group entries for each level so that user can see higher level picture more easily. It also helps to find out which component is most costly. The output will look like below: 15.11% swapper 14.97% [kernel.vmlinux] 0.09%