Re: [PATCH 15/16] vc_screen: extract vcs_read_buf_header

2020-08-25 Thread Peilin Ye
On Tue, Aug 25, 2020 at 06:59:35PM +0200, Greg KH wrote: > On Tue, Aug 25, 2020 at 12:48:04PM -0400, Peilin Ye wrote: > > Hi all, > > > > Link: > > https://syzkaller.appspot.com/bug?id=f332576321998d36cd07d09c9c1268cfed1895c9 > > > > As reported by syzbot, vcs_read_buf() is overflowing

Re: [PATCH 15/16] vc_screen: extract vcs_read_buf_header

2020-08-25 Thread Greg KH
On Tue, Aug 25, 2020 at 12:48:04PM -0400, Peilin Ye wrote: > Hi all, > > Link: > https://syzkaller.appspot.com/bug?id=f332576321998d36cd07d09c9c1268cfed1895c9 > > As reported by syzbot, vcs_read_buf() is overflowing `con_buf16`, since > this patch removed the following check: > > -

Re: [PATCH 15/16] vc_screen: extract vcs_read_buf_header

2020-08-25 Thread Peilin Ye
Hi all, Link: https://syzkaller.appspot.com/bug?id=f332576321998d36cd07d09c9c1268cfed1895c9 As reported by syzbot, vcs_read_buf() is overflowing `con_buf16`, since this patch removed the following check: - if (count > CON_BUF_SIZE) { - count = CON_BUF_SIZE;

[PATCH 15/16] vc_screen: extract vcs_read_buf_header

2020-08-18 Thread Jiri Slaby
The attribute header handling is terrible in vcs_read_buf. Separate it to a new function and simply do memmove (of up to 4 bytes) to the start of the con_buf -- if user seeked. Signed-off-by: Jiri Slaby --- drivers/tty/vt/vc_screen.c | 31 ++- 1 file changed, 18