Re: [PATCH 16/16] alsa sound support for mips

2007-04-20 Thread Atsushi Nemoto
On Wed, 18 Apr 2007 22:13:02 +0800, Fuxin Zhang <[EMAIL PROTECTED]> wrote: > >> +#if defined(__mips__) && defined(CONFIG_DMA_NONCOHERENT) > >> + /* all mmap using uncached mode */ > >> + area->vm_page_prot = pgprot_noncached(area->vm_page_prot); > >> + area->vm_flags |= ( VM_RESERVED | VM_IO);

Re: [PATCH 16/16] alsa sound support for mips

2007-04-20 Thread Atsushi Nemoto
On Wed, 18 Apr 2007 22:13:02 +0800, Fuxin Zhang [EMAIL PROTECTED] wrote: +#if defined(__mips__) defined(CONFIG_DMA_NONCOHERENT) + /* all mmap using uncached mode */ + area-vm_page_prot = pgprot_noncached(area-vm_page_prot); + area-vm_flags |= ( VM_RESERVED | VM_IO);

Re: [PATCH 16/16] alsa sound support for mips

2007-04-18 Thread Fuxin Zhang
vaddr = runtime->dma_area + offset; +#if defined(__mips__) && defined(CONFIG_DMA_NONCOHERENT) Please use CONFIG_MIPS instead of __mips__ in #if / #ifdefs. The question if #ifdefing is the right approach to solve this problem is something else but I think no, I

Re: [PATCH 16/16] alsa sound support for mips

2007-04-18 Thread Ralf Baechle
On Sun, Apr 15, 2007 at 11:26:05PM +0800, [EMAIL PROTECTED] wrote: (Adding a few more people to the cc'list) > sound/core/pcm_native.c | 10 ++ > sound/core/sgbuf.c |9 + > 2 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/sound/core/pcm_native.c

Re: [PATCH 16/16] alsa sound support for mips

2007-04-18 Thread Ralf Baechle
On Sun, Apr 15, 2007 at 11:26:05PM +0800, [EMAIL PROTECTED] wrote: (Adding a few more people to the cc'list) sound/core/pcm_native.c | 10 ++ sound/core/sgbuf.c |9 + 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/sound/core/pcm_native.c

Re: [PATCH 16/16] alsa sound support for mips

2007-04-18 Thread Fuxin Zhang
vaddr = runtime-dma_area + offset; +#if defined(__mips__) defined(CONFIG_DMA_NONCOHERENT) Please use CONFIG_MIPS instead of __mips__ in #if / #ifdefs. The question if #ifdefing is the right approach to solve this problem is something else but I think no, I would