Re: [PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-10 Thread Jaegeuk Kim
On Sat, May 09, 2015 at 05:25:54AM +0100, Al Viro wrote: > On Fri, May 08, 2015 at 09:20:51PM -0700, Jaegeuk Kim wrote: > > This patch implements encryption support for symlink. > > > > The codes refered the ext4 symlink path. > > ext4 symlink patches are seriously misguided - don't mix

Re: [PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-10 Thread Jaegeuk Kim
On Sat, May 09, 2015 at 05:25:54AM +0100, Al Viro wrote: On Fri, May 08, 2015 at 09:20:51PM -0700, Jaegeuk Kim wrote: This patch implements encryption support for symlink. The codes refered the ext4 symlink path. ext4 symlink patches are seriously misguided - don't mix encrypted and

Re: [PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-08 Thread Al Viro
On Fri, May 08, 2015 at 09:20:51PM -0700, Jaegeuk Kim wrote: > This patch implements encryption support for symlink. > > The codes refered the ext4 symlink path. ext4 symlink patches are seriously misguided - don't mix encrypted and unencrypted cases in the same inode_operations. NAK. -- To

[PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-08 Thread Jaegeuk Kim
This patch implements encryption support for symlink. The codes refered the ext4 symlink path. Signed-off-by: Uday Savagaonkar Signed-off-by: Theodore Ts'o Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs_crypto.h | 2 - fs/f2fs/namei.c | 138

[PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-08 Thread Jaegeuk Kim
This patch implements encryption support for symlink. The codes refered the ext4 symlink path. Signed-off-by: Uday Savagaonkar savag...@google.com Signed-off-by: Theodore Ts'o ty...@mit.edu Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs_crypto.h | 2 - fs/f2fs/namei.c |

Re: [PATCH 16/18] f2fs crypto: add symlink encryption

2015-05-08 Thread Al Viro
On Fri, May 08, 2015 at 09:20:51PM -0700, Jaegeuk Kim wrote: This patch implements encryption support for symlink. The codes refered the ext4 symlink path. ext4 symlink patches are seriously misguided - don't mix encrypted and unencrypted cases in the same inode_operations. NAK. -- To