Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-27 Thread Pavel Machek
Hi! > > > > > - err = ht16k33_brightness_set(priv, MAX_BRIGHTNESS); > > > > > + of_property_read_u32(node, "color", ); > > > > > + seg->led.name = devm_kasprintf(dev, GFP_KERNEL, > > > > > + DRIVER_NAME ":%s:" LED_FUNCTION_BACKLIGHT, > > > > > +

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-24 Thread Geert Uytterhoeven
Hi Pavel, On Tue, Mar 23, 2021 at 9:40 PM Pavel Machek wrote: > > CC linux-leds (which I intended, but forgot to add) > > > > cover letter at > > https://lore.kernel.org/linux-devicetree/20210322144848.1065067-1-ge...@linux-m68k.org/ > > Still does not tell me... riscv on fpga with 4 character

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-23 Thread Pavel Machek
Hi! > CC linux-leds (which I intended, but forgot to add) > > cover letter at > https://lore.kernel.org/linux-devicetree/20210322144848.1065067-1-ge...@linux-m68k.org/ Still does not tell me... riscv on fpga with 4 character display. What is this? :-). > On Tue, Mar 23, 2021 at 11:08 AM Robin

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-23 Thread Geert Uytterhoeven
CC linux-leds (which I intended, but forgot to add) cover letter at https://lore.kernel.org/linux-devicetree/20210322144848.1065067-1-ge...@linux-m68k.org/ On Tue, Mar 23, 2021 at 11:08 AM Robin van der Gracht wrote: > > On 2021-03-22 15:48, Geert Uytterhoeven wrote: > > Instantiate a single

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-23 Thread Robin van der Gracht
On 2021-03-22 15:48, Geert Uytterhoeven wrote: Instantiate a single LED for a segment display. This allows the user to control display brightness and blinking through the LED class API and triggers, and exposes the display color. Signed-off-by: Geert Uytterhoeven --- For setting display

[PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

2021-03-22 Thread Geert Uytterhoeven
Instantiate a single LED for a segment display. This allows the user to control display brightness and blinking through the LED class API and triggers, and exposes the display color. Signed-off-by: Geert Uytterhoeven --- For setting display brightness, this could use the existing backlight