Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-18 Thread Masami Hiramatsu
On Thu, 17 Jan 2019 17:15:27 -0800 Nadav Amit wrote: > > On Jan 17, 2019, at 3:58 PM, H. Peter Anvin wrote: > > > > On 1/16/19 11:54 PM, Masami Hiramatsu wrote: > >> On Wed, 16 Jan 2019 16:32:59 -0800 > >> Rick Edgecombe wrote: > >> > >>> From: Nadav Amit > >>> > >>> It seems dangerous to

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-18 Thread Masami Hiramatsu
On Thu, 17 Jan 2019 18:07:03 + Nadav Amit wrote: > > On Jan 16, 2019, at 11:54 PM, Masami Hiramatsu wrote: > > > > On Wed, 16 Jan 2019 16:32:59 -0800 > > Rick Edgecombe wrote: > > > >> From: Nadav Amit > >> > >> It seems dangerous to allow code modifications to take place > >>

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-17 Thread Nadav Amit
> On Jan 17, 2019, at 3:58 PM, H. Peter Anvin wrote: > > On 1/16/19 11:54 PM, Masami Hiramatsu wrote: >> On Wed, 16 Jan 2019 16:32:59 -0800 >> Rick Edgecombe wrote: >> >>> From: Nadav Amit >>> >>> It seems dangerous to allow code modifications to take place >>> concurrently with module

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-17 Thread H. Peter Anvin
On 1/16/19 11:54 PM, Masami Hiramatsu wrote: > On Wed, 16 Jan 2019 16:32:59 -0800 > Rick Edgecombe wrote: > >> From: Nadav Amit >> >> It seems dangerous to allow code modifications to take place >> concurrently with module unloading. So take the text_mutex while the >> memory of the module is

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-17 Thread H. Peter Anvin
On 1/17/19 10:07 AM, Nadav Amit wrote: >> On Jan 16, 2019, at 11:54 PM, Masami Hiramatsu wrote: >> >> On Wed, 16 Jan 2019 16:32:59 -0800 >> Rick Edgecombe wrote: >> >>> From: Nadav Amit >>> >>> It seems dangerous to allow code modifications to take place >>> concurrently with module unloading.

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-17 Thread Nadav Amit
> On Jan 16, 2019, at 11:54 PM, Masami Hiramatsu wrote: > > On Wed, 16 Jan 2019 16:32:59 -0800 > Rick Edgecombe wrote: > >> From: Nadav Amit >> >> It seems dangerous to allow code modifications to take place >> concurrently with module unloading. So take the text_mutex while the >> memory of

Re: [PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-16 Thread Masami Hiramatsu
On Wed, 16 Jan 2019 16:32:59 -0800 Rick Edgecombe wrote: > From: Nadav Amit > > It seems dangerous to allow code modifications to take place > concurrently with module unloading. So take the text_mutex while the > memory of the module is freed. At that point, since the module itself is

[PATCH 17/17] module: Prevent module removal racing with text_poke()

2019-01-16 Thread Rick Edgecombe
From: Nadav Amit It seems dangerous to allow code modifications to take place concurrently with module unloading. So take the text_mutex while the memory of the module is freed. Signed-off-by: Nadav Amit Signed-off-by: Rick Edgecombe --- kernel/module.c | 5 + 1 file changed, 5