Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-12-02 Thread Kalle Valo
nel.org; >> da...@davemloft.net; net...@vger.kernel.org; k...@kernel.org >> Subject: Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for >> .probe, .remove and .shutdown >> >> On Fri, 27 Nov 2020, Pkshih wrote: >> >> > On Fri, 202

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-30 Thread Lee Jones
gt; linux-wirel...@vger.kernel.org; > > da...@davemloft.net; net...@vger.kernel.org; k...@kernel.org > > Subject: Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, > > .remove and .shutdown > > > > On Fri, 27 Nov 2020, Pkshih wrote: > > > &g

RE: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-29 Thread Pkshih
..@vger.kernel.org; k...@kernel.org > Subject: Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, > .remove and .shutdown > > On Fri, 27 Nov 2020, Pkshih wrote: > > > On Fri, 2020-11-27 at 07:38 +, Lee Jones wrote: > > > On Fri, 27 Nov 2020, Pkshih wrote: &g

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-27 Thread Lee Jones
On Fri, 27 Nov 2020, Pkshih wrote: > On Fri, 2020-11-27 at 07:38 +, Lee Jones wrote: > > On Fri, 27 Nov 2020, Pkshih wrote: > > > > >  > > > The subject prefix doesn't need 'realtek:'; use 'rtw88:'. > > >  > > > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > > > > Also strip out other

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-27 Thread Pkshih
On Fri, 2020-11-27 at 07:38 +, Lee Jones wrote: > On Fri, 27 Nov 2020, Pkshih wrote: > > >  > > The subject prefix doesn't need 'realtek:'; use 'rtw88:'. > >  > > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > > > Also strip out other duplicates from driver specific headers. > > >  > >

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-26 Thread Lee Jones
On Fri, 27 Nov 2020, Pkshih wrote: > > The subject prefix doesn't need 'realtek:'; use 'rtw88:'. > > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > > Also strip out other duplicates from driver specific headers. > > > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-26 Thread Pkshih
The subject prefix doesn't need 'realtek:'; use 'rtw88:'. On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > Also strip out other duplicates from driver specific headers. > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter > uses some defines from the former.  It avoids

[PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-26 Thread Lee Jones
Also strip out other duplicates from driver specific headers. Ensure 'main.h' is explicitly included in 'pci.h' since the latter uses some defines from the former. It avoids issues like: from drivers/net/wireless/realtek/rtw88/rtw8822be.c:5: drivers/net/wireless/realtek/rtw88/pci.h:209:28: