On Mon, Apr 22, 2013 at 12:18 PM, Lee Jones wrote:
>> > + if ((cfg->dir == STEDMA40_PERIPH_TO_MEM) ||
>> > + (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) {
>>
>> Why would you need your own direction defines, I see that there is not much
>> diff between these and what dmaengine defines, so
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote:
> d40_phy_cfg is now only ever called to configure physical channels, so
> there's no requirement to pass though an argument describing the type
> of channel and to subsequently test for it.
>
> Cc: Vinod Koul
> Cc: Dan Williams
> Cc: Per
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote:
d40_phy_cfg is now only ever called to configure physical channels, so
there's no requirement to pass though an argument describing the type
of channel and to subsequently test for it.
Cc: Vinod Koul vinod.k...@intel.com
On Mon, Apr 22, 2013 at 12:18 PM, Lee Jones lee.jo...@linaro.org wrote:
+ if ((cfg-dir == STEDMA40_PERIPH_TO_MEM) ||
+ (cfg-dir == STEDMA40_PERIPH_TO_PERIPH)) {
Why would you need your own direction defines, I see that there is not much
diff between these and what dmaengine
> > + if ((cfg->dir == STEDMA40_PERIPH_TO_MEM) ||
> > + (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) {
> Why would you need your own direction defines, I see that there is not much
> diff between these and what dmaengine defines, so perhpas you could use
> those?
Same with these ones,
+ if ((cfg-dir == STEDMA40_PERIPH_TO_MEM) ||
+ (cfg-dir == STEDMA40_PERIPH_TO_PERIPH)) {
Why would you need your own direction defines, I see that there is not much
diff between these and what dmaengine defines, so perhpas you could use
those?
Same with these ones, subsequent
> > + if ((cfg->dir == STEDMA40_PERIPH_TO_MEM) ||
> > + (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) {
> Why would you need your own direction defines, I see that there is not much
> diff between these and what dmaengine defines, so perhpas you could use
> those?
I agree. I'll speak to the
On Thu, Apr 18, 2013 at 11:11:59AM +0100, Lee Jones wrote:
> d40_phy_cfg is now only ever called to configure physical channels, so
> there's no requirement to pass though an argument describing the type
> of channel and to subsequently test for it.
>
> Cc: Vinod Koul
> Cc: Dan Williams
> Cc:
On Thu, Apr 18, 2013 at 11:11:59AM +0100, Lee Jones wrote:
d40_phy_cfg is now only ever called to configure physical channels, so
there's no requirement to pass though an argument describing the type
of channel and to subsequently test for it.
Cc: Vinod Koul vinod.k...@intel.com
Cc: Dan
+ if ((cfg-dir == STEDMA40_PERIPH_TO_MEM) ||
+ (cfg-dir == STEDMA40_PERIPH_TO_PERIPH)) {
Why would you need your own direction defines, I see that there is not much
diff between these and what dmaengine defines, so perhpas you could use
those?
I agree. I'll speak to the STE folk.
d40_phy_cfg is now only ever called to configure physical channels, so
there's no requirement to pass though an argument describing the type
of channel and to subsequently test for it.
Cc: Vinod Koul
Cc: Dan Williams
Cc: Per Forlin
Cc: Rabin Vincent
Signed-off-by: Lee Jones
---
d40_phy_cfg is now only ever called to configure physical channels, so
there's no requirement to pass though an argument describing the type
of channel and to subsequently test for it.
Cc: Vinod Koul vinod.k...@intel.com
Cc: Dan Williams d...@fb.com
Cc: Per Forlin per.for...@stericsson.com
Cc:
12 matches
Mail list logo
