Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 11:18:01AM +, Bernat, Yehezkel wrote: > Nothing that I'm aware of. OK. > Still, I like the idea of having a table-like construct somewhere in > the code to centralize the handling of various controller-specific > info (generation, DMA port, maybe more things in the

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 11:18:01AM +, Bernat, Yehezkel wrote: > Nothing that I'm aware of. OK. > Still, I like the idea of having a table-like construct somewhere in > the code to centralize the handling of various controller-specific > info (generation, DMA port, maybe more things in the

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Bernat, Yehezkel
riy.shevche...@linux.intel.com>; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the > switch structure > > On Sun, May 21, 2017 at 09:55:55AM +, Bernat, Yehezkel wrote: > > > > > > > -Original Message--

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Bernat, Yehezkel
irski ; > mario.limoncie...@dell.com; jared.doming...@dell.com; Andy Shevchenko > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the > switch structure > > On Sun, May 21, 2017 at 09:55:55AM +, Bernat, Yehezkel wrote: > >

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
org>; mario.limoncie...@dell.com; > > jared.doming...@dell.com; Andy Shevchenko > > <andriy.shevche...@linux.intel.com>; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the > > switch structure > > > > On

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
gt; > ; Jamet, Michael ; > > Bernat, Yehezkel ; Andy Lutomirski > > ; mario.limoncie...@dell.com; > > jared.doming...@dell.com; Andy Shevchenko > > ; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the >

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 08:07:08AM +, Levy, Amir (Jer) wrote: > On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > > On Sun, May 21, 2017 at

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 08:07:08AM +, Levy, Amir (Jer) wrote: > On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > > On Sun, May 21, 2017 at

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Bernat, Yehezkel
;andreas.noe...@gmail.com>; Jamet, Michael <michael.ja...@intel.com>; > Bernat, Yehezkel <yehezkel.ber...@intel.com>; Andy Lutomirski > <l...@kernel.org>; mario.limoncie...@dell.com; > jared.doming...@dell.com; Andy Shevchenko > <andriy.shevche...@linux.intel.com&

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Bernat, Yehezkel
jared.doming...@dell.com; Andy Shevchenko > ; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the > switch structure > > On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Levy, Amir (Jer)
On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > > > On Sun, May 21 2017, 07:47 AM,

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Levy, Amir (Jer)
On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > > > On Sun, May 21 2017, 07:47 AM,

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > > > On Thu, May 18, 2017 at 05:39:08PM

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > > > On Thu, May 18, 2017 at 05:39:08PM

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > > > + > > > > + default: > > > >

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-21 Thread Mika Westerberg
On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > > > + > > > > + default: > > > >

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Lukas Wunner
On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > > + > > > + default: > > > + sw->generation = 1; > > > + break; > > > > If someone adds

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Lukas Wunner
On Sun, May 21, 2017 at 05:29:47AM +, Levy, Amir (Jer) wrote: > On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > > + > > > + default: > > > + sw->generation = 1; > > > + break; > > > > If someone adds

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Levy, Amir (Jer)
On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > + > > + default: > > + sw->generation = 1; > > + break; > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but > forgets > to

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Levy, Amir (Jer)
On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > + > > + default: > > + sw->generation = 1; > > + break; > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but > forgets > to

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Lukas Wunner
On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > In some cases it is useful to know what is the Thunderbolt generation > the switch supports. This introduces a new field to struct switch that > stores the generation of the switch based on the device ID. > > Signed-off-by: Mika

Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-20 Thread Lukas Wunner
On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > In some cases it is useful to know what is the Thunderbolt generation > the switch supports. This introduces a new field to struct switch that > stores the generation of the switch based on the device ID. > > Signed-off-by: Mika

[PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-18 Thread Mika Westerberg
In some cases it is useful to know what is the Thunderbolt generation the switch supports. This introduces a new field to struct switch that stores the generation of the switch based on the device ID. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat

[PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

2017-05-18 Thread Mika Westerberg
In some cases it is useful to know what is the Thunderbolt generation the switch supports. This introduces a new field to struct switch that stores the generation of the switch based on the device ID. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: Michael Jamet ---