Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-11 Thread Vineet Gupta
On Wednesday 10 June 2015 04:23 PM, Peter Zijlstra wrote: > On Wed, Jun 10, 2015 at 09:17:16AM +, Vineet Gupta wrote: >> I wanted to clarify a couple of things >> (1) ACQUIRE barrier implies store/{store,load} while RELEASE implies >> {load,store}/store and given what DMB provides for ARCv2,

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-11 Thread Vineet Gupta
On Wednesday 10 June 2015 04:23 PM, Peter Zijlstra wrote: On Wed, Jun 10, 2015 at 09:17:16AM +, Vineet Gupta wrote: I wanted to clarify a couple of things (1) ACQUIRE barrier implies store/{store,load} while RELEASE implies {load,store}/store and given what DMB provides for ARCv2, smp_mb()

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-10 Thread Peter Zijlstra
On Wed, Jun 10, 2015 at 09:17:16AM +, Vineet Gupta wrote: > >> --- a/arch/arc/include/asm/spinlock.h > >> +++ b/arch/arc/include/asm/spinlock.h > >> @@ -22,24 +22,32 @@ static inline void arch_spin_lock(arch_spinlock_t > >> *lock) > >> { > >>unsigned int tmp = __ARCH_SPIN_LOCK_LOCKED__;

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-10 Thread Vineet Gupta
On Tuesday 09 June 2015 06:00 PM, Peter Zijlstra wrote: > On Tue, Jun 09, 2015 at 05:18:18PM +0530, Vineet Gupta wrote: > > Please try and provide at least _some_ Changelog body. > > Will do as comments in source as well as commit log in v2. >> diff --git a/arch/arc/include/asm/spinlock.h >>

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-10 Thread Peter Zijlstra
On Wed, Jun 10, 2015 at 09:17:16AM +, Vineet Gupta wrote: --- a/arch/arc/include/asm/spinlock.h +++ b/arch/arc/include/asm/spinlock.h @@ -22,24 +22,32 @@ static inline void arch_spin_lock(arch_spinlock_t *lock) { unsigned int tmp = __ARCH_SPIN_LOCK_LOCKED__; + smp_mb();

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-10 Thread Vineet Gupta
On Tuesday 09 June 2015 06:00 PM, Peter Zijlstra wrote: On Tue, Jun 09, 2015 at 05:18:18PM +0530, Vineet Gupta wrote: Please try and provide at least _some_ Changelog body. snip all atomic ops that return values Will do as comments in source as well as commit log in v2. diff --git

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-09 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:18:18PM +0530, Vineet Gupta wrote: Please try and provide at least _some_ Changelog body. > diff --git a/arch/arc/include/asm/spinlock.h b/arch/arc/include/asm/spinlock.h > index b6a8c2dfbe6e..8af8eaad4999 100644 > --- a/arch/arc/include/asm/spinlock.h > +++

[PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-09 Thread Vineet Gupta
Cc: Paul E. McKenney Cc: Peter Zijlstra (Intel) Signed-off-by: Vineet Gupta --- arch/arc/include/asm/atomic.h | 10 ++ arch/arc/include/asm/bitops.h | 12 arch/arc/include/asm/cmpxchg.h | 10 ++ arch/arc/include/asm/spinlock.h | 10 ++ 4 files changed,

[PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-09 Thread Vineet Gupta
Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra (Intel) pet...@infradead.org Signed-off-by: Vineet Gupta vgu...@synopsys.com --- arch/arc/include/asm/atomic.h | 10 ++ arch/arc/include/asm/bitops.h | 12 arch/arc/include/asm/cmpxchg.h | 10 ++

Re: [PATCH 18/28] ARC: add smp barriers around atomics per memory-barrriers.txt

2015-06-09 Thread Peter Zijlstra
On Tue, Jun 09, 2015 at 05:18:18PM +0530, Vineet Gupta wrote: Please try and provide at least _some_ Changelog body. snip all atomic ops that return values diff --git a/arch/arc/include/asm/spinlock.h b/arch/arc/include/asm/spinlock.h index b6a8c2dfbe6e..8af8eaad4999 100644 ---