Re: [PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Viresh Kumar
On 15 April 2014 01:08, Stephen Boyd wrote: > But see the comment above this assignment. The point is to avoid calling > the ->set_mode function. Okay, that was a stupid change :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Stephen Boyd
On 04/14/14 09:23, Viresh Kumar wrote: > tick_shutdown() calls clockevents_exchange_device() which already sets mode to > CLOCK_EVT_MODE_UNUSED Yes it does. > and so tick_shutdown() doesn't need to do it. > > Signed-off-by: Viresh Kumar > --- > kernel/time/tick-common.c | 1 - > 1 file

[PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Viresh Kumar
tick_shutdown() calls clockevents_exchange_device() which already sets mode to CLOCK_EVT_MODE_UNUSED and so tick_shutdown() doesn't need to do it. Signed-off-by: Viresh Kumar --- kernel/time/tick-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/time/tick-common.c

Re: [PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Viresh Kumar
On 15 April 2014 01:08, Stephen Boyd sb...@codeaurora.org wrote: But see the comment above this assignment. The point is to avoid calling the -set_mode function. Okay, that was a stupid change :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Viresh Kumar
tick_shutdown() calls clockevents_exchange_device() which already sets mode to CLOCK_EVT_MODE_UNUSED and so tick_shutdown() doesn't need to do it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/time/tick-common.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 18/38] tick-common: don't set mode to CLOCK_EVT_MODE_UNUSED in tick_shutdown()

2014-04-14 Thread Stephen Boyd
On 04/14/14 09:23, Viresh Kumar wrote: tick_shutdown() calls clockevents_exchange_device() which already sets mode to CLOCK_EVT_MODE_UNUSED Yes it does. and so tick_shutdown() doesn't need to do it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/time/tick-common.c | 1 -